[Bug 1926150] Re: [SRU] Backport JSON hooks 0.2

[Julian Andres Klode]

autopkgtests for apt itself have passed, verifying the fix. We still
battle with one apport regression on focal, but it seems unrelated -
they've failed before.

** Tags removed: verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute
** Tags added: verification-done verification-done-bionic verification-done-focal verification-done-hirsute

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1926150

Title:
  [SRU] Backport JSON hooks 0.2

Status in apt package in Ubuntu:
  Fix Released
Status in apt source package in Xenial:
  Fix Released
Status in apt source package in Bionic:
  Fix Committed
Status in apt source package in Focal:
  Fix Committed
Status in apt source package in Hirsute:
  Fix Committed
Status in apt source package in Impish:
  Fix Released

Bug description:
  [Impact]
  We want to be able to use JSON hooks 0.2 in xenial and later releases to display messages to users during dist-upgrade.

  For xenial, we backport the JSON hook support in its entirety, whereas
  for later releases, we only need to cherry-pick bugfixes and the v0.2
  improvements.

  [Test plan]
  We have included unit and integration tests for the new JSON code to test the writer and prevent regressions in future changes. Regressions in other parts of the code should be caught by the test suite.

  
  [Where problems could occur]
  There may be bugs in the JSON code (apt-private/private-json-hooks.*) and in the integration thereof. The JSON hook code is identical to 2.3.2, whereas the integration code needed slight adjustments.

  The integration changes are limited to adding the hooks, and (for
  xenial, already in later releases) collecting all unknown package
  names. We believe the regression potential of these changes to be
  fairly limited.

  However, errors in JSON hooks are fatal, so once JSON hooks are
  running, they can cause apt to fail, which has to be kept in mind.

  Existing JSON hooks might not expect the new notifications, and break,
  but we are only aware of the snapd hook and it ignores any unknown
  notifications, so that should not pose a problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1926150/+subscriptions