[Bug 1929122] Re: networkd crashes when advertising blackhole route thru BGP

[Launchpad Bug Tracker]

This bug was fixed in the package systemd - 245.4-4ubuntu3.7

---------------
systemd (245.4-4ubuntu3.7) focal; urgency=medium

  [ Andy Chi ]
  * debian/patches/lp1926547-hwdb-60-keyboard-Update-Dell-Privacy-Local-Mic-Mute-.patch
    - Apply upstream patch to correct key and device mapping.
      (LP: #1926547)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=62c3ce6d6b2cab762b24aa610d6d135a67bdd76a

  [ Dan Streetman ]
  * d/p/lp1921696/0001-rfkill-improve-error-logging.patch,
    d/p/lp1921696/0002-rfkill-use-short-writes-and-accept-long-reads.patch:
    Handle rfkill api change in kernel 5.10 (LP: #1921696)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=ff0c23ba4fbcfa7f68e98adb6d62798ce54ca1da
  * d/p/lp1929122-network-check-that-received-ifindex-is-valid.patch:
    Check if ifindex is valid (LP: #1929122)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=6378191818bc7d169b657e6f7a2b50cfddb4275e
  * d/p/lp1929560-network-move-set-MAC-and-set-nomaster-operations-out.patch:
    Move link mac and master config out of link_up() (LP: #1929560)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=28cff7ee02a9ebd4ab93026af9fceaa2283725b3
  * d/p/lp1902891-core-mount-mount-command-may-fail-after-adding-the-c.patch:
    Handle failed mount command (LP: #1902891)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=b425189a483d7455db870b0ec5b2443c0eea7d76
  * d/p/resolved-Mitigate-DVE-2018-0001-by-retrying-NXDOMAIN-with.patch,
    d/p/lp1880258-log-nxdomain-as-debug.patch,
    d/p/lp1785383-resolved-address-DVE-2018-0001.patch:
    - Use upstream patch for DVE-2018-0001 handling (LP: #1785383)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=ec45ebfee362ad3e429642f7519e8b88f16dc221

  [ Łukasz 'sil2100' Zemczak ]
  * d/p/lp1664844/0001-network-add-ActivationPolicy-configuration-parameter.patch,
    d/p/lp1664844/0002-test-add-ActivationPolicy-unit-tests.patch,
    d/p/lp1664844/0003-save-link-activation-policy-to-state-file-and-displa.patch:
    - add support for configuring the activation policy for an interface
      (LP: #1664844)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=94f7b72d8128c743f35b308101a87d2c53a4074c

 -- Dan Streetman <ddstreet at canonical.com>  Thu, 27 May 2021 11:16:17
-0400

** Changed in: systemd (Ubuntu Focal)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1929122

Title:
  networkd crashes when advertising blackhole route thru BGP

Status in systemd package in Ubuntu:
  Fix Released
Status in systemd source package in Bionic:
  Invalid
Status in systemd source package in Focal:
  Fix Released

Bug description:
  [impact]

  systemd-networkd crashes due to assertion failure

  [test case]

  run systemd-networkd and FRR as described in original description
  below

  [regression potential]

  and regression would likely involve incorrectly configured routes

  [scope]

  this is needed only for f

  this is fixed upstream by commit
  25b831bac8a5e545e1eda5199392c11c7aed4e42 which is first in v246, so
  this is fixed in groovy and later

  the code involved in this isn't present in b so this doesn't apply
  there

  [original description]

  lsb_release -rd
  Description:	Ubuntu 20.04.2 LTS
  Release:	20.04

  apt-cache policy systemd
  systemd:
    Installed: 245.4-4ubuntu3.6

  [Impact]
  Networkd crashes when a blackhole route (route aggregation is installed as a blackhole route) is advertised via FRR.

  [Fix]
  networkd should not crash

  [Test case]
  Bug was reported to systemd (not accepted because systemd version too old) where a test case is described: https://github.com/systemd/systemd/issues/19648 Lower in the comment you can find the full debug log from networkd.

  Here you can see the core dump:
  https://drive.google.com/file/d/1tCKiOSnGkLbx3w9du5_NNepkOQZC_hx7/view?usp=sharing

  For convenience I also packed the relevant parts of the prod env in a
  vagrant box showing the issue: vagrant init matijavizintin/networkd-
  debug

  After some more testing i noticed that immediately after the route is
  being advertised, networkd detects the change and crashes with
  "Assertion 'ifindex' failed at src/network/networkd-link.c:757,
  function link_get(). Aborting."

  Steps how it happens:
  1. networkd is running
  2. frr is started without advertising the aggregated address
  3. add aggregated address and reload frr
  4. blackhole route is installed and networkd crashes with the error above

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1929122/+subscriptions