[Bug 1931278] Re: Creating FIT images is not supported

[Loïc Minier]

thanks for the patch!

this might be easier to review as smaller atomic changes, but perhaps I
can still follow around the debdiff :)

1) The its files are data, so they should to /usr/share; I wouldn't
encourage local customizations by dropping them in /etc unless that's an
important function; a way to give control would be to install a local
flash-kernel database entry that overrides the shipped defaults for that
hardware; this should be possible with /etc/flash-kernel/db?

2) would you add the new Boot-FIT-Path and Boot-ITS-Path to README?

3) seems "Boot-ITS-Path: /.../foo.its" should be written "U-Boot-ITS-
Name: foo.its" and should be searched in the default flash-kernel
directory

4) would it be possible to avoid the cp calls for kernel and initrd and
just generate the fit image from their locations? the kernels / initrds
tend to be big, so I suspect this adds non-trivial time to the run on SD
cards

5) mkimage_fit(): why is padding needed? perhaps deserves a comment.
Should this be a config?

6) the full path name in DTB-Id is the first one in the database,
perhaps this suggests the corresponding deb should be in Required-
Packages? would help with d-i usage

6) "cd" looks pretty singular compared to rest of functions; could it be
avoided?

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to flash-kernel in Ubuntu.
https://bugs.launchpad.net/bugs/1931278

Title:
  Creating FIT images is not supported

Status in flash-kernel package in Ubuntu:
  New

Bug description:
  flash-kernel does currently not support creating FIT images method.
  The attached debdiff (for impish) supports that, and additionally add
  supports for the Kria SOM platform.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1931278/+subscriptions