[Bug 1929122] Re: networkd crashes when advertising blackhole route thru BGP

[Brian Murray]

Hello Matija, or anyone else affected,

Accepted systemd into focal-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/systemd/245.4-4ubuntu3.7 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: systemd (Ubuntu Focal)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-focal

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1929122

Title:
  networkd crashes when advertising blackhole route thru BGP

Status in systemd package in Ubuntu:
  Fix Released
Status in systemd source package in Bionic:
  Invalid
Status in systemd source package in Focal:
  Fix Committed

Bug description:
  [impact]

  systemd-networkd crashes due to assertion failure

  [test case]

  run systemd-networkd and FRR as described in original description
  below

  [regression potential]

  and regression would likely involve incorrectly configured routes

  [scope]

  this is needed only for f

  this is fixed upstream by commit
  25b831bac8a5e545e1eda5199392c11c7aed4e42 which is first in v246, so
  this is fixed in groovy and later

  the code involved in this isn't present in b so this doesn't apply
  there

  [original description]

  lsb_release -rd
  Description:	Ubuntu 20.04.2 LTS
  Release:	20.04

  apt-cache policy systemd
  systemd:
    Installed: 245.4-4ubuntu3.6

  [Impact]
  Networkd crashes when a blackhole route (route aggregation is installed as a blackhole route) is advertised via FRR.

  [Fix]
  networkd should not crash

  [Test case]
  Bug was reported to systemd (not accepted because systemd version too old) where a test case is described: https://github.com/systemd/systemd/issues/19648 Lower in the comment you can find the full debug log from networkd.

  Here you can see the core dump:
  https://drive.google.com/file/d/1tCKiOSnGkLbx3w9du5_NNepkOQZC_hx7/view?usp=sharing

  For convenience I also packed the relevant parts of the prod env in a
  vagrant box showing the issue: vagrant init matijavizintin/networkd-
  debug

  After some more testing i noticed that immediately after the route is
  being advertised, networkd detects the change and crashes with
  "Assertion 'ifindex' failed at src/network/networkd-link.c:757,
  function link_get(). Aborting."

  Steps how it happens:
  1. networkd is running
  2. frr is started without advertising the aggregated address
  3. add aggregated address and reload frr
  4. blackhole route is installed and networkd crashes with the error above

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1929122/+subscriptions