[Bug 1936370] Re: u-boot-sifive does not upgrade u-boot on disk

[Dimitri John Ledkov]

Testing out of ppa:


$ sudo strings /dev/disk/by-partlabel/loader* | grep 202 | grep U-Boot
U-Boot SPL 2021.01+dfsg-3ubuntu0~20.04.1 (Jun 25 2021 - 18:21:47 +0000)
U-Boot 2021.01+dfsg-3ubuntu0~20.04.1 (Jun 25 2021 - 18:21:47 +0000)


$ sudo apt install u-boot-sifive
Preparing to unpack .../u-boot-sifive_2021.01+dfsg-4ubuntu3_riscv64.deb ...
Unpacking u-boot-sifive:riscv64 (2021.01+dfsg-4ubuntu3) over (2021.01+dfsg-3ubuntu0~20.04.1) 
...
Setting up u-boot-sifive:riscv64 (2021.01+dfsg-4ubuntu3) ...
155+1 records in
155+1 records out
79363 bytes (79 kB, 78 KiB) copied, 0.0953994 s, 832 kB/s
1160+1 records in
1160+1 records out
594112 bytes (594 kB, 580 KiB) copied, 0.709527 s, 837 kB/s

$ sudo strings /dev/disk/by-partlabel/loader* | grep 202 | grep U-Boot
U-Boot SPL 2021.01+dfsg-4ubuntu3 (Jul 15 2021 - 12:01:50 +0000)
U-Boot 2021.01+dfsg-4ubuntu3 (Jul 15 2021 - 12:01:50 +0000)

Upgrade successful.

Testing boot logs now.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to u-boot in Ubuntu.
https://bugs.launchpad.net/bugs/1936370

Title:
  u-boot-sifive does not upgrade u-boot on disk

Status in u-boot package in Ubuntu:
  New
Status in u-boot source package in Focal:
  New
Status in u-boot source package in Hirsute:
  New
Status in u-boot source package in Impish:
  New

Bug description:
  [Impact]

   * u-boot-sifive package currently does not upgrade bootloader on
  loader1/loader2 partitions.

   * there have now been bugs identified, meaning that upgrading u-boot
  is required to upgrade from v5.8 kernel to v5.11 (i.e. either in-
  focal, or from focal to hirsute).

   * Add maintainer script that identifies if the machine one is running
  on is unleashed or unamtched, and appropriately upgrades the
  bootloader on loader1/loader2 partitions.

  [Test Plan]

   * Boot older unleashed or unmatched image

   * Check version strings of loader1/loader2 partitions

  $ sudo strings /dev/disk/by-partlabel/loader* | grep 202 | grep U-Boot

   * Upgrade u-boot-sifive to latest package

   * Check version strings of loader1/loader2 partitions, they should
  have changed

  $ sudo strings /dev/disk/by-partlabel/loader* | grep 202 | grep U-Boot

   * Reboot, and observe on the serial console that u-boot version
  number is incremented to the latest one.

   * Repeat the test twice, once with unleashed board, once with
  unmatched board

   * Upgrade the package under qemu VM and observe no side-effects / no
  attempts to upgrade anything.

  [Where problems could occur]

   * It is not possible to atomically upgrade loader1 and loader2 simultaniously.
   * A backup of loader1 and loader2 partitions is not stored anywhere.
   * Thus in case of errors rollback of older u-boot is not performed.
   * However if dd of one or the other partition fails, it is unlikely that one can restore the backup.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/1936370/+subscriptions