[Bug 1920836] Re: Show Extended Security Maintenence status

[Chad Smith]

Ultimately if we decide to go with #2 here's a patch that I think would
limit both the time cost of a remote uRL query and the noisy logging:


--- /usr/lib/python3/dist-packages/softwareproperties/gtk/utils.py	2021-06-10 23:20:22.000000000 -0600
+++ /usr/lib/python3/dist-packages/softwareproperties/gtk/utils.py.new	2021-07-14 15:19:14.485004311 -0600
@@ -76,23 +76,10 @@
 def get_ua_status():
     """Return a dict of all UA status information or empty dict on error."""
     # status.json will exist on any attached system or any unattached system
-    # which has already run `ua status`. Calling ua status directly on
-    # network disconnected machines will raise a TimeoutException trying to
-    # access contracts.canonical.com/v1/resources.
-    try:
-        # Success writes UA_STATUS_JSON
-        result = subprocess.run(['ua', 'status', '--format=json'], stdout=subprocess.PIPE)
-    except Exception as e:
-        print("Failed to call ubuntu advantage client:\n%s" % e)
-        return {}
-    if result.returncode != 0:
-        print("Ubuntu advantage client returned code %d" % result.returncode)
-        return {}
-
+    # which has already run `sudo ua status`.
     try:
         status_file = open(UA_STATUS_JSON, "r")
     except Exception as e:
-        print("No ua status file written:\n%s" % e)
         return {}
 
     with status_file as stream:

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/1920836

Title:
  Show Extended Security Maintenence status

Status in software-properties package in Ubuntu:
  Fix Released
Status in software-properties source package in Xenial:
  New
Status in software-properties source package in Bionic:
  Fix Committed
Status in software-properties source package in Focal:
  Fix Committed
Status in software-properties source package in Hirsute:
  Fix Committed

Bug description:
  [Impact]
  There is not currently a graphical method of determining if a system is subscribed to [Extended Security Maintenance](https://ubuntu.com/security/esm) updates. This is resolved by adding some [new UI](https://wiki.ubuntu.com/SoftwareUpdates#Extended_Security_Maintenance) to the software properties application.

  [Test Case]
  1. Install latest version of Ubuntu advantage:
  $ sudo add-apt-repository ppa:ua-client/stable
  $ sudo apt update
  $ sudo apt upgrade
  2. Open Software Properties
  3. Go to Updates tab.

  Expected result:
  Information is shown that indicates if this system is using Extended Security Maintenance updates, when updates will supported until, and a link to upgrade to ESM.

  Observed result:
  No ESM information currently shown.

  [Where problems could occur]
  - Software properties could hit a bug getting a response from the ua app. The current code carefully checks if and what is returned, falling back to a safe default behavior.
  - Launching software properties could trigger a bug in the ua app.
  - Software properties could show incorrect information, causing confusion for the user. The solution uses information from distro-info and the ua app which means software-properties contains no data about ESM, and instead relies on these apps that can be updated if things change.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1920836/+subscriptions