[Bug 1933093] Re: Drop old UC20 boot args

[Dimitri John Ledkov]

Did testflinger submit of

job_queue: rpi4b4g
provision_data:
    url: https://cdimage.ubuntu.com/ubuntu-core/20/dangerous-edge/20210706/ubuntu-core-20-armhf+raspi.img.xz
test_data:
  test_cmds: |
    ssh ubuntu@$DEVICE_IP snap list
    ssh ubuntu@$DEVICE_IP cat /proc/cmdline

which resulted in:

**************************************************
* Starting testflinger test phase on rpi4b8g-001 *

**************************************************

2021-07-07 14:49:49,500 rpi4b8g_001 INFO: DEVICE AGENT: BEGIN testrun
Name       Version                 Rev    Tracking     Publisher   Notes
core20     20210619                1074   latest/edge  canonical*  base
pi         20-1                    104    20/edge      canonical*  gadget
pi-kernel  5.4.0-1039.42           313    20/edge      canonical*  kernel
snapd      2.51.1+git809.gd43ffb4  12588  latest/edge  canonical*  snapd
 coherent_pool=1M 8250.nr_uarts=1 snd_bcm2835.enable_compat_alsa=0 snd_bcm2835.enable_hdmi=1 video=HDMI-A-1:1920x1080M at 60,margin_left=48,margin_right=48,margin_top=48,margin_bottom=48 smsc95xx.macaddr=DC:A6:32:AD:53:33 vc_mem.mem_base=0x3ec00000 vc_mem.mem_size=0x40000000  dwc_otg.lpm_enable=0 console=ttyS0,115200 elevator=deadline rng_core.default_quality=700 vt.handoff=2 quiet splash quiet splash snapd_recovery_mode=run snapd_recovery_system=20210706 panic=-1
2021-07-07 14:49:51,629 rpi4b8g_001 INFO: DEVICE AGENT: END testrun

again correct kernel commandline without the extra gpt_auto or
rd.systemd.unit options. on armhf this time.

** Tags removed: verification-needed verification-needed-focal
** Tags added: verification-done verification-done-focal

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to flash-kernel in Ubuntu.
https://bugs.launchpad.net/bugs/1933093

Title:
  Drop old UC20 boot args

Status in flash-kernel package in Ubuntu:
  Fix Released
Status in flash-kernel source package in Focal:
  Fix Committed

Bug description:
  [Impact]

   * During early development of uc20 core-initrd additional kernel
  command-line arguments were required. These were dropped on 20th of
  April 2020 in the pc gadget.

   * They made it into flash-kernel, and were not dropped at the same
  time.

   * They are now redundant and mostly harmless during normal mode of
  operation. However, they get in the way when trying to debug pi
  initrd.

  [Test Plan]

   * Rebuild pi gadget with this update

   * Boot UC20 on pi-armhf or pi-arm64

   * Check that kernel command does not have "systemd.gpt_auto=0
  rd.systemd.unit=basic.target"

  [Where problems could occur]

   * snapd now has new functionality to append or replace kernel command
  line. The remain argument that remains is "panic=-1". I am not too
  sure if the flash-kernel uboot script actually is compatible with the
  snapd's cmdline full / extra functionality.

  [Other Info]

   * Reported at https://github.com/snapcore/core-initrd/pull/28

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1933093/+subscriptions