[Bug 1906436] Re: Resolve autopkgtest failures Pep8/pyflakes on Xenial and Bionic

[Launchpad Bug Tracker]

This bug was fixed in the package update-notifier - 3.192.1.9

---------------
update-notifier (3.192.1.9) bionic; urgency=medium

  * data/apt_check.py: Update UA Infra: ESM product name and doc url
    (LP: #1901627)
    - data/apt_check.py: Update name and URL
    - tests/test_motd.py: adapt unittests to match new behavior
    - po/*.po: translation files with intltool-update -r
  * Fix pep8/pyflakes autopkgtest failures (LP: #1906436)
    - d/control: add explicit pep8 build-requires dependency
    - test_motd.py: remove unused imports
    - pyflakes: data/backend_helper fix unittests for unreferenced
      variables
    - data/apt_check & data/backend_helper: resolve underindent pep8 issues
      backport of 9e0f7ee50 [ Brian Murray ]
    - data/apt_check.py, data/package-data-downloader, tests/test_pep8.py:
      + update the code formating to be not hit W504 warnings,
        change to ignore W503 and be consistent with update-manager.
        [ Andrea Azzarone ]
    - INSTALL, data/hooks.py, tests/test_package-data-downloader.py:
      Fix E117 over-indented pep issues. [ Gianfranco Costamagna ]
    - test_motd.py: Remove unused imports [ Julian Andres Klode ]
    - pyflakes: data/backend_helper fix unittests for unreferenced variables

update-notifier (3.192.1.8) bionic; urgency=medium

  [ Andreas Hasenack ]
  * data/apt_check.py: Update ESM security pockets names (LP: #1881632)
    - the UbuntuESM pocket was renamed from <distro>-security to
      <distro>-infra-security
    - new origin UbuntuESMApps, with a corresponding pocket of
      <distro>-apps-security

  [ Brian Murray ]
  * data/apt_check.py: modify wording and output regarding ESM support.
    (LP: #1842508)

  [ Julian Andres Klode ]
  * Handle missing cases of LP: #1822340, where we told people ESM is not
    enabled, but not how to enable it.
  * Fix multiple disabled ESM repositories being counted as enabled ones.

 -- Chad Smith <chad.smith at canonical.com>  Mon, 30 Nov 2020 14:25:35
-0700

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-notifier in Ubuntu.
https://bugs.launchpad.net/bugs/1906436

Title:
  Resolve autopkgtest failures Pep8/pyflakes on Xenial and Bionic

Status in update-notifier package in Ubuntu:
  Fix Released
Status in update-notifier source package in Xenial:
  Fix Released
Status in update-notifier source package in Bionic:
  Fix Released

Bug description:
  [Impact]

  - autopkgtest failures on for Xenial(pep8) and Bionic(pep8 & pyflakes)

  - Cherry-picking upstream changes for ESM Product renaming and messaging
    for bug 1901627 trigger these issues.

  - Also changes in the Xenial base cloud-images used for testing dropped
    pep8 package from the build environment and unittests rely on calling
    pep8 on Xenial and Bionic. minimally a build-depends on pep8 needs to be
    added and pep8 test failures addresssed for Xenial. Bionic also needs
    minor pyflakes fixes from master.

  [Test Case]

   * Testing is "implicit", build time and autopkgtest tests have to
     succeed as we'd expect anyway.

  [Where problems could occur]

   * These are whitespace/indent/style changes that should (tm) be totally
     without an effect other than for the code-checker. Never the less by
     changing code always something could happen. In this case the changes
     are local to apt_check, package-data-downloader, backend_helper and
     hooks. So in these subfunctions of update-notifier issue would be
     expected.

  [Other Info]

   * This does not directly affect Focal or later because update-notifier
     moved to pycodestyle validation in tests instead of using pep8.
   * The Xenial upload will throw errors of some epxect-to-fail tests that 
     are misleading. We've spent too many iterations on looking at these so 
     they are silenced while fixing the test anyway.

  --- ---

  Initial pep8 build-dependency error on Xenial/Bionic autopkgtests:

  Fetched 4 B in 0s (0 B/s)
  ....Get:1 http://localhost:17195/canary-file.txt [4 B]
  Fetched 4 B in 0s (0 B/s)
  .E
  ======================================================================
  ERROR: test_pep8_clean (test_pep8.TestPep8Clean)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/tmp/autopkgtest.RQGkx9/build.3cC/src/tests/test_pep8.py", line 32, in test_pep8_clean
      ["pep8", "--ignore={0}".format(IGNORE_PEP8), py_file])
    File "/usr/lib/python3.5/subprocess.py", line 557, in call
      with Popen(*popenargs, **kwargs) as p:
    File "/usr/lib/python3.5/subprocess.py", line 947, in __init__
      restore_signals, start_new_session)
    File "/usr/lib/python3.5/subprocess.py", line 1551, in _execute_child
      raise child_exception_type(errno_num, err_msg)
  FileNotFoundError: [Errno 2] No such file or directory: 'pep8'

  Once resolving the build-depends: example pep8 test failures: seen
  running nosetests3 on update-notifier on Xenial amd Bionic

  ./tmp/autopkgtest.wN63go/build.IFg/src/tests/../data/apt_check.py:157:21:
  W503 line break before binary operator ....

  autopackage test failure logs showing missing pep8 dependency:

  xenial: update-notifier/3.168.11
     - autopkg logs: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz

  bionic: update-notifier/3.192.1.8
      - autopkg failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-notifier/20201016_045656_8c126@/log.gz

  focal: update-notifier/3.192.30.1
    - rejected this upload in Focal to reduce SRU thrashing because a followup will be provided for Focal anyway to sync with Xenial and Bionic.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1906436/+subscriptions