[Bug 1915923] Re: update-pciids in pciutils fails to create hard link

[Brian Murray]

** Tags removed: rls-ff-incoming

** Also affects: pciutils (Ubuntu Focal)
   Importance: Undecided
       Status: New

** Changed in: pciutils (Ubuntu Focal)
   Importance: Undecided => High

** Changed in: pciutils (Ubuntu Focal)
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to pciutils in Ubuntu.
https://bugs.launchpad.net/bugs/1915923

Title:
  update-pciids in pciutils fails to create hard link

Status in pciutils package in Ubuntu:
  New
Status in pciutils source package in Focal:
  Triaged

Bug description:
  Running on Ubuntu 20.04 LTS, the `.old` file does not seem to be
  cleaned up properly.

  It seems someone forgot to add the "-f" from the respective upstream
  commit:
  https://github.com/pciutils/pciutils/commit/b6a0091e4a17dcc01c84dfe233e861fe6e82b1c4

  First run:
  ```
  $ sudo sh -x /usr/sbin/update-pciids
  + set -e
  + SRC=https://pci-ids.ucw.cz/v2.2/pci.ids
  + DEST=/usr/share/misc/pci.ids
  + PCI_COMPRESSED_IDS=
  + GREP=grep
  + [  = -q ]
  + quiet=false
  + touch /usr/share/misc/pci.ids
  + [  = 1 ]
  + which bzip2
  + DECOMP=bzip2 -d
  + SRC=https://pci-ids.ucw.cz/v2.2/pci.ids.bz2
  + which curl
  + DL=curl -o /usr/share/misc/pci.ids.new https://pci-ids.ucw.cz/v2.2/pci.ids.bz2
  + false
  + curl -o /usr/share/misc/pci.ids.new https://pci-ids.ucw.cz/v2.2/pci.ids.bz2
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  100  265k  100  265k    0     0   634k      0 --:--:-- --:--:-- --:--:--  635k
  + bzip2 -d
  + grep ^C  /usr/share/misc/pci.ids.neww
  + [ -f /usr/share/misc/pci.ids ]
  + ln /usr/share/misc/pci.ids /usr/share/misc/pci.ids.old
  + chmod -f --reference=/usr/share/misc/pci.ids.old /usr/share/misc/pci.ids.neww
  + mv /usr/share/misc/pci.ids.neww /usr/share/misc/pci.ids
  + rm /usr/share/misc/pci.ids.new
  + [ /usr/share/misc/pci.ids != /usr/share/misc/pci.ids ]
  + false
  + echo Done.
  Done.
  ```

  Second run:
  ```
  $ sudo sh -x /usr/sbin/update-pciids
  + set -e
  + SRC=https://pci-ids.ucw.cz/v2.2/pci.ids
  + DEST=/usr/share/misc/pci.ids
  + PCI_COMPRESSED_IDS=
  + GREP=grep
  + [  = -q ]
  + quiet=false
  + touch /usr/share/misc/pci.ids
  + [  = 1 ]
  + which bzip2
  + DECOMP=bzip2 -d
  + SRC=https://pci-ids.ucw.cz/v2.2/pci.ids.bz2
  + which curl
  + DL=curl -o /usr/share/misc/pci.ids.new https://pci-ids.ucw.cz/v2.2/pci.ids.bz2
  + false
  + curl -o /usr/share/misc/pci.ids.new https://pci-ids.ucw.cz/v2.2/pci.ids.bz2
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  100  265k  100  265k    0     0   420k      0 --:--:-- --:--:-- --:--:--  419k
  + bzip2 -d
  + grep ^C  /usr/share/misc/pci.ids.neww
  + [ -f /usr/share/misc/pci.ids ]
  + ln /usr/share/misc/pci.ids /usr/share/misc/pci.ids.old
  ln: failed to create hard link '/usr/share/misc/pci.ids.old': File exists
  ```

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pciutils/+bug/1915923/+subscriptions