[Bug 1951069] Re: [MIR] raqm

[Didier Roche]

xReview for Package: raqm

[Summary]
MIR team ACK, under the constraint that the autopktests possible enhancements are a little bit more explored (see below) and that check (I didn’t see any rationale in the request) on why raqm hasn’t been updated despite having new releases for a year now.

Recommended TODOs:
- check if the autopkgtests can be enhanced
- check why 0.7.1 and 0.7.2 ara available (from Nov 2020 for the former) without any update on debian/ubuntu. As the package hasn’t changed for multiple releases. I think those fixes are not distro-patched either.

[Duplication]
There is no other package in main providing the same functionality.

[Dependencies]
OK:
- no other Dependencies to MIR due to this
- checked with check-mir
- not listed in seeded-in-ubuntu
- none of the (potentially auto-generated) dependencies (Depends
  and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have odd Built-Using entries

OK:
- not a go package, no extra constraints to consider in that regard
- No vendoring used, all Built-Using are in main

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- no new python2 dependency

Problems:
- the autopkgtest test is trivial: build it, run it, don’t check the output. Can we maybe check the output given known inputs and see what is returned is expected?

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking is in place
- d/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is slow, but seems in maintainance mode
- Debian/Ubuntu update history is slow
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings (only older lintian version used)
- d/rules is rather clean
- It is not on the lto-disabled list
  (fix, or the work-around should be directly in the package,
  see https://launchpad.net/ubuntu/+source/lto-disabled-list)

Problems:
- the current release and previous one is not packaged. The previous release is more than one year old.

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks

** Changed in: raqm (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to raqm in Ubuntu.
https://bugs.launchpad.net/bugs/1951069

Title:
  [MIR] raqm

Status in raqm package in Ubuntu:
  Incomplete

Bug description:
  [Availability]
  The package is already in universe.

  [Rationale]
  The package is a new dependency of pillow, which is already in main.

  [Security]
  There are currently no CVEs mentioning raqm, and the project is actively maintained upstream.

  [Quality assurance]
  There are no currently outstanding bugs in Launchpad for the package, there is a good test suite within the project itself (which is run during the build), and the package includes a build test for autopkgtest.

  [UI standards]
  Only applicable insofar as raqm adds advanced text layout capabilities to the Pillow library.

  [Dependencies]
  The build+installation dependencies of the library are:
  * freetype -- already in main
  * fribidi -- already in main
  * harfbuzz -- already in main

  [Standards compliance]
  The package installs its libraries in the typical location (e.g. /usr/lib/x86_64-linux-gnu/ on a PC).

  [Maintenance]
  The package will be maintained by the Ubuntu Foundations team.

  [Background information]
  The Pillow package cannot currently migrate due to component mismatch errors as raqm is a new dependency added in Pillow 8.2.0 (or more specifically Pillow 8.2.0 "link[ed] against the system version of libraqm at build time rather than at runtime by default").

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/raqm/+bug/1951069/+subscriptions