[Bug 1924766] Please test proposed package

[Brian Murray]

Hello Lucas, or anyone else affected,

Accepted update-notifier into bionic-proposed. The package will build
now and be available at https://launchpad.net/ubuntu/+source/update-
notifier/3.192.1.10 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
bionic to verification-done-bionic. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-bionic. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-notifier in Ubuntu.
https://bugs.launchpad.net/bugs/1924766

Title:
  update-notifier does not handle ESM Apps in the apt-check script

Status in update-notifier package in Ubuntu:
  In Progress
Status in update-notifier source package in Xenial:
  In Progress
Status in update-notifier source package in Bionic:
  Fix Committed
Status in update-notifier source package in Focal:
  Fix Committed
Status in update-notifier source package in Groovy:
  New
Status in update-notifier source package in Hirsute:
  Fix Committed
Status in update-notifier source package in Impish:
  In Progress

Bug description:
  [Impact]
  When ESM Apps goes into production we want to be able to advertise it to our users through MOTD.
  Currently, update-notifier apt-check does not take into consideration the exclusive packages of ESM Apps, which is a problem.

  [Test case]

  To reproduce the issue, you can:

  1. Launch a xenial vm
  2. Install the latest version of uaclient from the stable ppa:
     https://launchpad.net/~ua-client/+archive/ubuntu/stable/
  3. Change the following line on `/etc/ubuntu-advantage/uaclient.conf` from
     
     contract_url: 'https://contracts.canonical.com'

     To:

     contract_url: 'https://contracts.staging.canonical.com'

  4. Attach a staging token to uaclient thorough:

      ua attach YOUR_STAGING_TOKEN

  5. Run /usr/lib/update-notifier/apt-check --human-readable
  6. Verify that no mention to ESM Apps is made and that update-notifier puts all of the ESM packages in the same bucket

  
  To verify that the error is fixed:

  1.Perform all the stages above until step 4
  2 Install the new update-notifier from this ppa:
    https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa
  3. Verify now that ESM Apps is reflected in the message

  [Where problems could occur]

  The changes in this package should only be seen when MOTD is getting a
  new message. If that script fails for some reason, it seems that MOTD
  will only not present the message, which is doesn't seem to be a
  system critical issue.

  [Discussion]

  With ESM Apps going to production soon, we have decided to update the
  messages delivered by update-notifier apt-check to address the package
  count of ESM Apps and the possibility of installing more upgrades if
  the user has ESM Apps disabled.

  We are also updating other parts of the messaging as well. First, we only display ESM Infra status
  on ESM distros. However, we will keep showing the ESM Infra package count on all of them.

  For ESM Apps, we are only performing the alerts (For example, that you
  might have x packages updates if ESM Apps is installed) if the user is
  on a LTS distro.

  Finally, we are also addressing this bug here:
  https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315

  Where we were incorrectly counting ESM packages even if the user did
  not have access to those services.

  == Changelog ==

    + data/apt-check
      - Make distinction of ESM Apps and ESM Infra when doing package count
      - Only count ESM packages if the user has access to the service (LP #1883315)
      - Only display ESM Infra alerts if the distro is ESM

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1924766/+subscriptions