[Bug 1888352] Re: use builtin dump_acpi_tables.py in hookutils

[Yuan-Chen Cheng]

this is output of dump_acpi_tables.py on that machine.

** Attachment added: "dump_acpi_tables.py.log"
   https://bugs.launchpad.net/apport/+bug/1888352/+attachment/5408887/+files/dump_acpi_tables.py.log

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/1888352

Title:
  use builtin dump_acpi_tables.py in hookutils

Status in Apport:
  New
Status in OEM Priority Project:
  In Progress
Status in apport package in Ubuntu:
  Fix Released
Status in apport source package in Focal:
  Fix Committed
Status in apport source package in Groovy:
  Fix Released

Bug description:
  1. add apcidump to hookutils.py:attach_hardware and use the builtin dump_acpi_tables.py.
  2. remove explicit acpidump from oem-getlogs to use the builtin one.
  3. refine usage string in oem-getlogs.

  To SRU to focal:

  [Impact]

   * for OEM project, lts is been used. And collect log is important.
     With built-in tool to get acpidump, we don't need to install
     extra tool in the end-customer's machine. That make it much
     easier for the oem process.

   * By call built-in utility, we no lounger need to install extra
     tools to collect data that's both complete and convenient for
     HWE people to work on.

  [Test Case]

   * before this applied, run oem-getlog without install acpidump. 
     we can't get the dump data. After this applied, we can just dump
     the data HWE need.

   * test step: install the new package, run

     sudo -E oem-getlogs [-c case_id] to get the

     use apport-unpack to unpack the apport file.

     check the acpidump file. HWE people know much better on check
     the acpidump file. Give the dump_acpi_tables.py just updated and SRUed
     by HWE/ACPI/UEFI expert, it's pretty safe to do so.

  [Regression Potential]

   * Given the modification change the way to collect log, even it
     failed, it won't break apport itself. Just the collected log
     might contain data not so valid.

   * Given acpidump mostly used by HWE/ACIP/UEFI expert, and they
     just reviewed and updated the dump_acpi_tables.py script, I
     believe it will have good quality.

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/1888352/+subscriptions