[Bug 1886572] Re: Remove uptime from the motd-news user agent
Launchpad Bug Tracker
1886572 at bugs.launchpad.net
Wed Sep 2 20:33:30 UTC 2020
This bug was fixed in the package base-files - 10.1ubuntu2.10
---------------
base-files (10.1ubuntu2.10) bionic; urgency=medium
[ Andreas Hasenack ]
* motd/50-motd-news: don't include uptime in the user-agent string
(LP: #1886572)
* Move the /etc/default/motd-news conffile to the motd-news-config
package (LP: #1888575):
- d/base-files.maintscript: remove /etc/default/motd-news config file
on upgrade
- d/control: break on ubuntu-server << 1.417.5 to force an upgrade if
it is installed, which will pull motd-news-config and the conffile
back in
- d/motd-news-config.postinst:
+ handle the upgrade case where the motd-news config file was
changed while it belonged to base-files
+ disable motd-news if the config file was removed by hand before
the upgrade
- d/postinst.in: signal the motd-news-config package if the
motd-news config file was removed manually before the upgrade
- d/control: new motd-news-config package, carrying the
configuration file for the /etc/update-motd.d/50-motd-news script.
- d/rules, d/motd-news-config.install: /e/d/motd-news is in the
motd-news-config package now
[ Steve Langasek ]
* motd/50-motd-news: use wget instead of curl, since wget is standard but
curl is optional (LP: #1888572):
- This changes the timeout behavior slightly because wget does not have
an exact equivalent to curl's --max-time argument, we are using
--timeout instead.
-- Andreas Hasenack <andreas at canonical.com> Thu, 13 Aug 2020 15:59:47
-0300
** Changed in: base-files (Ubuntu Bionic)
Status: Fix Committed => Fix Released
** Changed in: base-files (Ubuntu Focal)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to base-files in Ubuntu.
https://bugs.launchpad.net/bugs/1886572
Title:
Remove uptime from the motd-news user agent
Status in base-files package in Ubuntu:
Fix Released
Status in base-files source package in Xenial:
Fix Released
Status in base-files source package in Bionic:
Fix Released
Status in base-files source package in Focal:
Fix Released
Bug description:
[Impact]
The uptime value in the user-agent string sent to the motd-news server is unused and not necessary. It should be removed.
[Test Case]
Inspect the /etc/update-motd.d/50-motd-news script and verify that uptime is no longer used.
Previous version:
$ grep uptime /etc/update-motd.d/50-motd-news
# Some messages may only be pertinent before or after some amount of uptime
read up idle < /proc/uptime
uptime="uptime/$up/$idle"
USER_AGENT="curl/$curl_ver $lsb $platform $cpu $uptime cloud_id/$cloud_id"
Updated version:
$ grep uptime /etc/update-motd.d/50-motd-news
(no output)
[Regression Potential]
The server side, if it were checking this value, could be surprised by this change.
[Other Info]
N/A
[Original Description]
I don't why that was included but it shouldn't be. Please remove it.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/base-files/+bug/1886572/+subscriptions
More information about the foundations-bugs
mailing list