[Bug 1876495] Re: bash-completion incorrectly shows source package names for APT

[Julian Andres Klode]

There are two hilarious bugs in here:

(1) We call _config->FindB("APT::Cache::AllNames","false"), trying to
set the default to false, but we pass a char* instead, which gets cast
to true (as it's != nullptr). So, pkgnames always runs with --all-names

(2) We accidentally exclude virtual packages, hence why we've not seen
that before by excluding any package that does not have a version, by
checking I.FindPkg("any")->VersionList == 0.

Now the trick here is that the check in (2) fails for source packages,
as I.FindPkg("any") does not find a valid package (it returns a pointer
to the start of the cache), but that generates a != 0 VersionList.

Anyway, I've got the fix.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1876495

Title:
  bash-completion incorrectly shows source package names for APT

Status in apt package in Ubuntu:
  In Progress
Status in bash-completion package in Ubuntu:
  Invalid

Bug description:
  Steps to reproduce:
  1. Have Ubuntu 20.04 LTS installed
  2. Open terminal, enter one of the commands below

  2a.     apt install brisk<Tab>
  2b.     apt source brisk-menu<Tab>
  2c.     apt-get install brisk<Tab>
  2d.     apt-get source brisk-menu<Tab>
  2e.     apt-cache policy brisk<Tab> 

  Expected results:
  * The bash-completion should not lead to package name as there are no binary packages named with starting part "brisk" (see https://packages.ubuntu.com/search?suite=all&searchon=names&keywords=brisk )

  Actual results:
  * all commands below get completed to the name of source package - in this example named "brisk-menu"
  (see https://packages.ubuntu.com/search?suite=all&section=all&arch=any&keywords=brisk&searchon=sourcenames). This is absolutely unexpected, as user can not really install this package in binary form.

  ProblemType: Bug
  DistroRelease: Ubuntu Kylin 20.04
  Package: bash-completion 1:2.10-1ubuntu1 [origin: Ubuntu]
  ProcVersionSignature: Ubuntu 5.4.0-28.32-lowlatency 5.4.30
  Uname: Linux 5.4.0-28-lowlatency x86_64
  NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
  ApportVersion: 2.20.11-0ubuntu27
  Architecture: amd64
  CasperMD5CheckResult: skip
  CurrentDesktop: MATE
  Date: Sat May  2 20:35:48 2020
  Dependencies:
   
  InstallationDate: Installed on 2020-04-22 (9 days ago)
  InstallationMedia: Ubuntu-MATE 20.04 LTS "Focal Fossa" - Release amd64 (20200422)
  PackageArchitecture: all
  SourcePackage: bash-completion
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1876495/+subscriptions