[Bug 1905987] [NEW] germinate-update-metapackage: wrong handling of seed duplicates

[Paride Legovini]

Public bug reported:

When generating the d/changelog entries germinate-update-metapackage
compares the "old" (pre-update) dependencies to the "new" ones, and
checks if packages have been added or removed. However if a package is
seeded more than once, it will always appear as an "added" dependency,
even if already present in the "old" dependencies, and no actual change
is made.

This is due to the fact that germinate_update_metapackage.py stores the
"old" dependencies in a set (duplicates not allowed), and "new"
dependencies in a list (duplicates allowed).

For an actual case where this was hit see:

https://code.launchpad.net/~paride/ubuntu/+source/ubuntu-meta/+git
/ubuntu-meta/+merge/394577

Also see how the changelog line

  * Added wpasupplicant to desktop-raspi

appears more than once in the ubuntu-meta changelog.

** Affects: germinate (Ubuntu)
     Importance: Undecided
     Assignee: Paride Legovini (paride)
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to germinate in Ubuntu.
https://bugs.launchpad.net/bugs/1905987

Title:
  germinate-update-metapackage: wrong handling of seed duplicates

Status in germinate package in Ubuntu:
  New

Bug description:
  When generating the d/changelog entries germinate-update-metapackage
  compares the "old" (pre-update) dependencies to the "new" ones, and
  checks if packages have been added or removed. However if a package is
  seeded more than once, it will always appear as an "added" dependency,
  even if already present in the "old" dependencies, and no actual
  change is made.

  This is due to the fact that germinate_update_metapackage.py stores
  the "old" dependencies in a set (duplicates not allowed), and "new"
  dependencies in a list (duplicates allowed).

  For an actual case where this was hit see:

  https://code.launchpad.net/~paride/ubuntu/+source/ubuntu-meta/+git
  /ubuntu-meta/+merge/394577

  Also see how the changelog line

    * Added wpasupplicant to desktop-raspi

  appears more than once in the ubuntu-meta changelog.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/germinate/+bug/1905987/+subscriptions