[Bug 1881074] Re: Support btrfs when writable is converted to btrfs
Alfonso Sanchez-Beato
1881074 at bugs.launchpad.net
Thu May 28 08:14:39 UTC 2020
Some comments on the debdiff:
Use
blkid -s TYPE "$writable_part" -o value
instead of
blkid -s TYPE "$writable_part" | awk '{print $2}' | grep -o '".*"' | tr -d '"'
No need to redirect to >>$LOGFILE in resize_filesystem() which is
already redirected when called. Also, you should not redirect to
/dev/kmsg - I guess that was for debugging purposes.
Is it really necessary to mount the partition to find out the filesystem usage?
"btrfs filesystem show" apparently can work on devices according to [1]. But it also looks like btrfs commands are mostly used with mounted systems, so it is fine if you want to keep things like that.
Finally, you will need to use copy_exec for btrfs and blkid to the
fixtrtc hook to get them included in the initramfs (although maybe blkid
comes from busybox in this case, not sure).
Otherwise, looks good to me.
[1] https://btrfs.wiki.kernel.org/index.php/Manpage/btrfs-filesystem
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to initramfs-tools-devices in
Ubuntu.
https://bugs.launchpad.net/bugs/1881074
Title:
Support btrfs when writable is converted to btrfs
Status in initramfs-tools-devices package in Ubuntu:
New
Bug description:
It's a special case that we may need to convert rootfs from ext4 to
btrfs, and we have to resize btrfs inside initramfs as well.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/initramfs-tools-devices/+bug/1881074/+subscriptions
More information about the foundations-bugs
mailing list