[Bug 1876902] Re: subiquity crashed on entering help menu after upgrade

[Michael Hudson-Doyle]

** Changed in: subiquity (Ubuntu)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to subiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1876902

Title:
  subiquity crashed on entering help menu after upgrade

Status in Ubuntu on IBM z Systems:
  Fix Released
Status in subiquity package in Ubuntu:
  Fix Released

Bug description:
  WHile trying to test an updated installer from edge ("subiquity-channel=latest/edge"),
  I fired up a z/VM guest and the installer loaded and informed me about an updated version:

  "Version 20.04.3+git61.1404fee2 of the installer is now available
  (20.04.3 is currently running).  " (1846).

  So the initial version of the installer was "20.04.3", hence I updated to the edge version.
  The update completed and after the update I landed again at the initial screen (language selection).

  Checking there the installer version via the help menu, let me think
  that I'm still running on 20.04.3, hence I stopped the ssh session
  (~.) and restarted the remote installer session.

  When I'm now hitting F1 to reach the help menu, trying to identify the
  version of the installer that is currently running, the installer
  crashes like this:

     - generating crash report
  report saved to /var/crash/1588677563.383518219.ui.crash
  Traceback (most recent call last):
    File "/snap/subiquity/1846/usr/bin/subiquity", line 11, in <module>
      load_entry_point('subiquity==0.0.5', 'console_scripts', 'subiquity-tui')()
    File "/snap/subiquity/1846/lib/python3.6/site-packages/subiquity/cmd/tui.py", line 203, in main
      subiquity_interface.run()
    File "/snap/subiquity/1846/lib/python3.6/site-packages/subiquity/core.py", line 270, in run
      super().run()
    File "/snap/subiquity/1846/lib/python3.6/site-packages/subiquitycore/core.py", line 684, in run
      self.urwid_loop.run()
    File "/snap/subiquity/1846/usr/lib/python3/dist-packages/urwid/main_loop.py", line 286, in run
      self._run()
    File "/snap/subiquity/1846/usr/lib/python3/dist-packages/urwid/main_loop.py", line 384, in _run
      self.event_loop.run()
    File "/snap/subiquity/1846/usr/lib/python3/dist-packages/urwid/main_loop.py", line 1484, in run
      reraise(*exc_info)
    File "/snap/subiquity/1846/usr/lib/python3/dist-packages/urwid/compat.py", line 58, in reraise
      raise value
    File "/snap/subiquity/1846/usr/lib/python3.6/asyncio/events.py", line 145, in _run
      self._callback(*self._args)
    File "/snap/subiquity/1846/usr/lib/python3/dist-packages/urwid/raw_display.py", line 404, in <lambda>
      event_loop, callback, self.get_available_raw_input())
    File "/snap/subiquity/1846/usr/lib/python3/dist-packages/urwid/raw_display.py", line 502, in parse_input
      callback(processed, processed_codes)
    File "/snap/subiquity/1846/usr/lib/python3/dist-packages/urwid/main_loop.py", line 411, in _update
      self.process_input(keys)
    File "/snap/subiquity/1846/usr/lib/python3/dist-packages/urwid/main_loop.py", line 517, in process_input
      something_handled |= bool(self.unhandled_input(k))
    File "/snap/subiquity/1846/usr/lib/python3/dist-packages/urwid/main_loop.py", line 563, in unhandled_input
      return self._unhandled_input(input)
    File "/snap/subiquity/1846/lib/python3.6/site-packages/subiquity/core.py", line 411, in unhandled_input
      if not self.ui.right_icon.showing_something:
  AttributeError: 'HelpButton' object has no attribute 'showing_something'
  Connection to hwe0006 closed.

  Having a look at the shell I can see that I'm now on the latest
  version:

  root at ubuntu-server:/# snap list
  Name       Version                 Rev   Tracking       Publisher   Notes
  core18     20200311                1704  latest/stable  canonical*  base
  snapd      2.44.3                  7262  latest/stable  canonical*  snapd
  subiquity  20.04.3+git61.1404fee2  1846  latest/edge    canonical*  classic
  root at ubuntu-server:/#

  Please see the attached tgz with /var/crash and /var/log.

  (I left the system in that state - just in case more investigations
  are needed ...)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1876902/+subscriptions