[Bug 1878378] [NEW] add_mountroot_fail_hook uses wrong target name

[Roland Kaufmann]

Public bug reported:

Upon boot of a system that uses LVM2 you get the message:

ln: /tmp/mountroot-fail-hooks.d//scripts/init-premount/lvm2: No such
file or directory

This is because the script /usr/share/initramfs-tools/scripts/init-
premount/lvm2 uses the add_mountroot_fail_hook function from /usr/share
/initramfs-tools/scripts/functions (which is sources right before), but
this function contains a bug that takes the full path of the source
script instead of the given argument as name for the target.

Version of Ubuntu: 20.04 LTS
Version of initramfs-tools: 0.136ubuntu6

For a live installation, this may be fixed with (all on one line):

sudo sed -i 's,\(ln -s "\$0" /tmp/mountroot-fail-
hooks\.d/\)"\$0",\1"\$1",' /usr/share/initramfs-tools/scripts/functions
&& sudo update-initramfs -u

and verified by checking that this message now disappears on next boot:

sudo journalctl -b | grep mountroot-fail-hooks

A proposed patch for the source distribution is attached.

** Affects: initramfs-tools (Ubuntu)
     Importance: Undecided
         Status: New

** Patch added: "Proposed fix"
   https://bugs.launchpad.net/bugs/1878378/+attachment/5370864/+files/0001-Use-specified-target-name-for-mountroot-failure-hook.patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to initramfs-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1878378

Title:
  add_mountroot_fail_hook uses wrong target name

Status in initramfs-tools package in Ubuntu:
  New

Bug description:
  Upon boot of a system that uses LVM2 you get the message:

  ln: /tmp/mountroot-fail-hooks.d//scripts/init-premount/lvm2: No such
  file or directory

  This is because the script /usr/share/initramfs-tools/scripts/init-
  premount/lvm2 uses the add_mountroot_fail_hook function from
  /usr/share/initramfs-tools/scripts/functions (which is sources right
  before), but this function contains a bug that takes the full path of
  the source script instead of the given argument as name for the
  target.

  Version of Ubuntu: 20.04 LTS
  Version of initramfs-tools: 0.136ubuntu6

  For a live installation, this may be fixed with (all on one line):

  sudo sed -i 's,\(ln -s "\$0" /tmp/mountroot-fail-
  hooks\.d/\)"\$0",\1"\$1",' /usr/share/initramfs-
  tools/scripts/functions && sudo update-initramfs -u

  and verified by checking that this message now disappears on next
  boot:

  sudo journalctl -b | grep mountroot-fail-hooks

  A proposed patch for the source distribution is attached.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/initramfs-tools/+bug/1878378/+subscriptions