[Bug 1834534] Re: [20.04 FEAT] Enhanced tooling for guest images

Dimitri John Ledkov launchpad at surgut.co.uk
Tue Mar 17 14:12:44 UTC 2020


CHANGELOG.md                           |  22 +-
 Makefile                               |   4 +-
 README.md                              |   7 +-
 cmsfs-fuse/dasd.c                      |   1 +
 cmsfs-fuse/helper.h                    |   2 -
 cpumf/Makefile                         |   3 +-
 cpumf/bin/cpumf_helper.in              | 155 +++----
 cpumf/data/cpum-cf-extended-z15.ctr    | 376 +++++++++++++++
 cpumf/data/cpum-cf-hw-counter.map      |   5 +-
 genprotimg/.gitignore                  |   5 +
 genprotimg/Makefile                    |  26 ++
 genprotimg/README.md                   | 101 ++++
 genprotimg/boot/.gitignore             |   4 +
 genprotimg/boot/Makefile               |  97 ++++
 genprotimg/boot/common_memory_layout.h |  25 +
 genprotimg/boot/head.S                 |  29 ++
 genprotimg/boot/stage3a.c              |  62 +++
 genprotimg/boot/stage3a.h              |  34 ++
 genprotimg/boot/stage3a.lds.S          | 103 +++++
 genprotimg/boot/stage3a_init.S         |  26 ++
 genprotimg/boot/stage3b.c              |  77 ++++
 genprotimg/boot/stage3b.h              |  42 ++
 genprotimg/boot/stage3b.lds.S          |  87 ++++
 genprotimg/boot/stage3b_reloc.S        |  53 +++
 genprotimg/man/Makefile                |  12 +
 genprotimg/man/genprotimg.8            |  97 ++++
 genprotimg/src/Makefile                | 101 ++++
 genprotimg/src/common.h                |  39 ++
 genprotimg/src/genprotimg.c            | 181 ++++++++
 genprotimg/src/include/pv_crypto_def.h |  25 +
 genprotimg/src/include/pv_hdr_def.h    |  84 ++++
 genprotimg/src/pv/pv_args.c            | 405 ++++++++++++++++
 genprotimg/src/pv/pv_args.h            |  53 +++
 genprotimg/src/pv/pv_comp.c            | 446 ++++++++++++++++++
 genprotimg/src/pv/pv_comp.h            |  78 ++++
 genprotimg/src/pv/pv_comps.c           | 252 ++++++++++
 genprotimg/src/pv/pv_comps.h           |  42 ++
 genprotimg/src/pv/pv_error.c           |  37 ++
 genprotimg/src/pv/pv_error.h           |  62 +++
 genprotimg/src/pv/pv_hdr.c             | 293 ++++++++++++
 genprotimg/src/pv/pv_hdr.h             |  36 ++
 genprotimg/src/pv/pv_image.c           | 820 +++++++++++++++++++++++++++++++++
 genprotimg/src/pv/pv_image.h           |  68 +++
 genprotimg/src/pv/pv_ipib.c            | 128 +++++
 genprotimg/src/pv/pv_ipib.h            |  27 ++
 genprotimg/src/pv/pv_opt_item.c        |  26 ++
 genprotimg/src/pv/pv_opt_item.h        |  20 +
 genprotimg/src/pv/pv_stage3.c          | 164 +++++++
 genprotimg/src/pv/pv_stage3.h          |  30 ++
 genprotimg/src/utils/align.h           |  24 +
 genprotimg/src/utils/buffer.c          |  69 +++
 genprotimg/src/utils/buffer.h          |  31 ++
 genprotimg/src/utils/crypto.c          | 798 ++++++++++++++++++++++++++++++++
 genprotimg/src/utils/crypto.h          | 104 +++++
 genprotimg/src/utils/file_utils.c      | 234 ++++++++++
 genprotimg/src/utils/file_utils.h      |  34 ++
 include/boot/ipl.h                     | 190 ++++++++
 include/boot/linux_layout.h            |  34 ++
 include/boot/loaders_layout.h          |  32 ++
 {zipl => include}/boot/s390.h          | 131 ++----
 include/boot/sigp.h                    |  56 +++
 include/lib/util_base.h                |  17 +-
 include/lib/util_file.h                |   2 +-
 include/lib/zt_common.h                |  56 +++
 scripts/dbginfo.sh                     |   7 +-
 scripts/zfcpdbf                        |  44 +-
 zconf/qeth/misc.h                      |   2 -
 zdev/include/attrib.h                  |   4 +-
 zdev/include/misc.h                    |   2 +-
 zdev/src/device.c                      |   9 +-
 zdev/src/export.c                      |   4 +-
 zdev/src/table_attribs.c               |  14 +-
 zdev/src/zfcp_host.c                   |  22 +
 zdev/src/zfcp_lun.c                    |  34 +-
 zdump/zg.c                             |   2 +-
 zdump/zg.h                             |   3 -
 zipl/boot/Makefile                     |  16 +-
 zipl/boot/cio.c                        |   2 +-
 zipl/boot/cio.h                        |   2 +-
 zipl/boot/ebcdic.c                     |  30 ++
 zipl/boot/ebcdic.h                     |  45 ++
 zipl/boot/ebcdic_conv.c                | 167 +++++++
 zipl/boot/ebcdic_conv.h                |  21 +
 zipl/boot/eckd2.c                      |   2 +-
 zipl/boot/eckd2dump.c                  |   2 +-
 zipl/boot/error.h                      |   6 +
 zipl/boot/fba2.c                       |   2 +-
 zipl/boot/fba2dump.c                   |   2 +-
 zipl/boot/head.S                       |   6 +-
 zipl/boot/kdump.c                      |   2 +-
 zipl/boot/kdump.h                      |   2 +-
 zipl/boot/libc.c                       | 364 ++++++++++-----
 zipl/boot/libc.h                       |  37 +-
 zipl/boot/menu.c                       |  11 +-
 zipl/boot/menu.h                       |   1 -
 zipl/boot/sclp.c                       |  69 ++-
 zipl/boot/sclp.h                       |  30 +-
 zipl/boot/sclp_stage3.c                |   1 +
 zipl/boot/sclp_stage3.h                |   2 +
 zipl/boot/stage2.c                     |   2 +-
 zipl/boot/stage2.h                     |   3 +-
 zipl/boot/stage2dump.c                 |   1 +
 zipl/boot/stage2dump.h                 |   2 +-
 zipl/boot/stage3.c                     | 166 +------
 zipl/boot/stage3.h                     | 149 +-----
 zipl/boot/stage3.lds                   |   2 +-
 zipl/boot/tape0.S                      |  20 +-
 zipl/boot/tape2dump.c                  |   2 +-
 zipl/include/zipl.h                    |  19 +-
 zipl/man/zipl.conf.5.in                |   6 +-
 110 files changed, 7261 insertions(+), 764 deletions(-)

Is the diffstat vs what is currently uploaded in Ubuntu Focal.

Which i will need to do line by line review. Including simple refactors
from 2018 and whitespace changes.

I did an upload into Ubuntu of everything that was in master in the
February 12 code-drop. So very surprised to see commits and code
authored way earlier than February 12th in the later code drops.

Please do a lot more frequent code-drops upstream.

Please submit refactors and code-drop them upstream master *separate*
from the feature development.

Please code-drop bug fixes separate from whitespace changes / feature
development.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to s390-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1834534

Title:
  [20.04 FEAT] Enhanced tooling for guest images

Status in Ubuntu on IBM z Systems:
  Triaged
Status in s390-tools package in Ubuntu:
  New

Bug description:
  Enhanced end user tools for KVM setups.
  Contribution targeted via s390-tools 2.10.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1834534/+subscriptions



More information about the foundations-bugs mailing list