[Bug 1680224] Please test proposed package

[Brian Murray]

Hello Mark, or anyone else affected,

Accepted autofs into bionic-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/autofs/5.1.2-1ubuntu3.2 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
bionic to verification-done-bionic. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-bionic. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to autofs in Ubuntu.
https://bugs.launchpad.net/bugs/1680224

Title:
  auto.smb fails on Windows administrative shares

Status in autofs package in Ubuntu:
  Fix Released
Status in autofs source package in Bionic:
  Fix Committed
Status in autofs source package in Eoan:
  Fix Committed
Status in autofs source package in Focal:
  Fix Committed

Bug description:
  [Impact]

   - Unable to get windows admin share (C$) mounted through autofs
   - All other shares seem to work fine
   - Mount / command line work fine for admin shares

  [Test Case]

  ----
  #!/bin/bash

  set -e
  set -x

  sudo apt update && sudo apt dist-upgrade -y
  sudo apt install autofs samba smbclient cifs-utils -y
  sudo mkdir /myshare /c
  echo "This is myshare." | sudo tee /myshare/myshare.txt
  echo "This is C." | sudo tee /c/c.txt
  echo "
  [myshare]
      path = /myshare
      read only = yes
      guest ok = yes

  [C$]
      path = /c
      read only = yes
      guest ok = yes
  " | sudo tee -a /etc/samba/smb.conf

  echo "/cifs /etc/auto.smb --timeout=300" | sudo tee -a
  /etc/auto.master

  sudo systemctl restart smbd nmbd autofs

  echo "
  Run these commands now:

  cat /cifs/localhost/myshare/myshare.txt
  cat /cifs/localhost/C$/c.txt
  cat /cifs/localhost/C\\$/c.txt
  ----

  [Regression Potential]

   - Could, in theory, brake SMB auto-mounts (specially related to $ shares)
   - Minor potential (patching auto.smb file only)
   - Patch is *removing* a substitution instead of adding one

  [Other Info]

  This is probably related to #385244.

  I've been unable to get a Windows administrative share (ie. C$)
  mounted through Autofs. Non-administrative shares work fine.
  Administrative shares are accessible with the same credentials from
  other Windows 10 workstations and through smbclient on Ubuntu (16.04
  LTS) machines. Administrative shares can even be mounted using the
  same credentials via mount on the command-line. However, autofs will
  not mount the same shares, using the same credentials, on the same
  Ubuntu machine.

  Administrative shares are listed under /cifs/WindowsHostName, but a cd
  /cifs/WindowsHostname/C$ results in "-bash: cd: C$: No such file or
  directory" from the shell and the following output from 'automount -f
  -v':

  -----
  attempting to mount entry /cifs/WindowsHostname/C$
  >> Retrying with upper case share name
  >> mount error(6): No such device or address
  >> Refer to the mount.cifs(8) manual page (e.g. man mount.cifs)
  mount(generic): failed to mount //WindowsHostname/C\$ (type cifs) on /cifs/WindowsHostname/C$
  failed to mount /cifs/WindowsHostname/C$
  -----

  Notice that mount complains of failing to mount 'C\$' rather than
  'C$'. If the bit of awk script that escapes the $ is removed, it then
  fails to mount 'C', which is also no good. I think if we could
  actually get mount to try to mount 'C$', it would work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/autofs/+bug/1680224/+subscriptions