[Bug 1884485] [NEW] 15+1533136590.3beb971-0ubuntu1 fail to build with gcc9(focal)

[Ivan Hu]

Public bug reported:

The latest shim upload does not seem able to build with gcc9(under Focal).
Got error message,
MokManager.c: In function ‘write_back_mok_list’:
MokManager.c:1080:19: error: taking address of packed member of ‘struct <anonymous>’ may result in an unaligned pointer value [-Werror=address-of-packed-member]
 1080 |   if (CompareGuid(&(list[i].Type), &X509_GUID) == 0)
      |                   ^~~~~~~~~~~~~~~
...


But it can be built with the version shim 15+1552672080.a4a1fbe-0ubuntu1.
It seems because the Gcc9 fixing patches,
MokManager: Use CompareMem on MokListNode.Type instead of CompareGuid(aaa09b35e73c4a35fc119d225e5241199d7cf5aa)
MokManager: avoid -Werror=address-of-packed-member(58532e12e9aa207e3c14096f4f5d6f7900130c52)
are removed from 15+1552672080.a4a1fbe-0ubuntu1.

** Affects: shim (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to shim in Ubuntu.
https://bugs.launchpad.net/bugs/1884485

Title:
  15+1533136590.3beb971-0ubuntu1 fail to build with gcc9(focal)

Status in shim package in Ubuntu:
  New

Bug description:
  The latest shim upload does not seem able to build with gcc9(under Focal).
  Got error message,
  MokManager.c: In function ‘write_back_mok_list’:
  MokManager.c:1080:19: error: taking address of packed member of ‘struct <anonymous>’ may result in an unaligned pointer value [-Werror=address-of-packed-member]
   1080 |   if (CompareGuid(&(list[i].Type), &X509_GUID) == 0)
        |                   ^~~~~~~~~~~~~~~
  ...

  
  But it can be built with the version shim 15+1552672080.a4a1fbe-0ubuntu1.
  It seems because the Gcc9 fixing patches,
  MokManager: Use CompareMem on MokListNode.Type instead of CompareGuid(aaa09b35e73c4a35fc119d225e5241199d7cf5aa)
  MokManager: avoid -Werror=address-of-packed-member(58532e12e9aa207e3c14096f4f5d6f7900130c52)
  are removed from 15+1552672080.a4a1fbe-0ubuntu1.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/shim/+bug/1884485/+subscriptions