[Bug 1875045] Re: Ubiquity 20.04 exports existing ZFS pools

[Brendan_P]

Hello Folks,

I think I experienced this bug upgrading Ubuntu from 18.04 > 20.04 last
night. If not, apologies.

I have the OS running on USB drive, normal install with all my data in a
ZFS pool. After roboot/upgrade completed my ZFS pool is no longer
listed.

Not a ZFS guru so nervous of next steps to resolve the issue. Any
suggestions/help truly appreciated.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1875045

Title:
  Ubiquity 20.04 exports existing ZFS pools

Status in ubiquity package in Ubuntu:
  Fix Released
Status in ubiquity source package in Focal:
  Fix Released

Bug description:
  [Impact]

   * Ubiquity unmounts everything that could be mounted on the target
  file system when it starts and on tear down. For ZFS it exports all
  the pools.

   * If a user had existing pools, they are exported too.

   * This fix only unmount pool that are used as a target for the
  installation, leaving alone any other pool.

  [Test Case]

   1. Boot a live session
   2. Create a new pool with:
  $ zpool create -R /mnt tpool /dev/vda
   3. Verify that the pool is created with zpool list
   4. Start ubiquity
   5. Quit ubiquity

  => Verify that the pool is still there with zpool list. Without the
  fix, tpool is exported.

  [Regression Potential]

   * Low risk of regression. Worst case, the bug is not fixed and pools
  are still unmounted or none of the pools are exported. This case would
  prevent to do 2 installations in a row from the same live session.

  [Other info]

   * Already shipped in Groovy.

  ===

  For unclear reasons (18.04 didn't have this issue), Ubiquity on 20.04
  exports existing ZFS pools, (very) shortly after execution.

  To repeat (assumes a `/dev/sda` disk):

  - start a 20.04 Ubuntu Desktop live media
  - open a terminal
  - create a zfs pool: `zpool create test /dev/sda`
  - verify that it's been created: `zpool list`
  - launch ubiquity: `ubiquity`
  - open a separate terminal
  - list the ZFS pools: `zpool list`

  no pools are now listed.

  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: ubiquity 20.04.15
  ProcVersionSignature: Ubuntu 5.4.0-26.30-generic 5.4.30
  Uname: Linux 5.4.0-26-generic x86_64
  NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
  ApportVersion: 2.20.11-0ubuntu27
  Architecture: amd64
  CasperMD5CheckMismatches: ./casper/vmlinuz
  CasperMD5CheckResult: skip
  CasperVersion: 1.445
  CurrentDesktop: MATE
  Date: Sat Apr 25 15:21:25 2020
  InstallCmdLine: BOOT_IMAGE=/casper/vmlinuz file=/cdrom/preseed/ubuntu-mate.seed quiet splash ---
  LiveMediaBuild: Ubuntu-MATE 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
  ProcEnviron:
   TERM=xterm-256color
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=C.UTF-8
   SHELL=/bin/bash
  SourcePackage: ubiquity
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1875045/+subscriptions