[Bug 1886197] Re: FTBFS in b due to libseccomp change

[Dan Streetman]

** Description changed:

  [impact]
  
  systemd FTBFS in b because __NR__sysctl was force-defined by libseccomp
  in 2.4.1-0ubuntu0.18.04.2, but that force-defining was (correctly)
  reverted in the latest version 2.4.3-1ubuntu3.18.04.2.
  
  On arm64, __NR__sysctl is not defined, so the build now fails, e.g.:
  https://launchpadlibrarian.net/486997294/buildlog_ubuntu-bionic-arm64.systemd_237-3ubuntu10.42~202007031245~ubuntu18.04.1_BUILDING.txt.gz
  
  ../src/test/test-seccomp.c: In function ‘test_protect_sysctl’:
  ../src/test/test-seccomp.c:251:5: error: "__NR__sysctl" is not defined, evaluates to 0 [-Werror=undef]
-  #if __NR__sysctl > 0
-      ^~~~~~~~~~~~
+  #if __NR__sysctl > 0
+      ^~~~~~~~~~~~
  
  [test case]
  
  build systemd on bionic with latest packages (i.e. with latest
  libseccomp2 package)
  
  [regression potential]
  
  this adds a defined() check before comparing the __NR__sysctl value, so
  any regression would be limited to the specific function
  test_protect_sysctl() which is part of the test framework, thus leading
  to a failed build or incorrectly passed/failed test.
  
  [scope]
  
  this is needed only in Bionic.
+ 
+ This is fixed upstream by commit
+ 4df8fe8415eaf4abd5b93c3447452547c6ea9e5f which is included in v244 and
+ later, so this is fixed already for Focal and later.

** Bug watch added: github.com/systemd/systemd/issues #14031
   https://github.com/systemd/systemd/issues/14031

** Also affects: systemd via
   https://github.com/systemd/systemd/issues/14031
   Importance: Unknown
       Status: Unknown

** Changed in: systemd (Ubuntu)
       Status: New => Fix Released

** Changed in: systemd (Ubuntu Bionic)
     Assignee: (unassigned) => Dan Streetman (ddstreet)

** Changed in: systemd (Ubuntu Bionic)
   Importance: Undecided => High

** Changed in: systemd (Ubuntu Bionic)
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1886197

Title:
  FTBFS in b due to libseccomp change

Status in systemd:
  Unknown
Status in systemd package in Ubuntu:
  Fix Released
Status in systemd source package in Bionic:
  In Progress

Bug description:
  [impact]

  systemd FTBFS in b because __NR__sysctl was force-defined by
  libseccomp in 2.4.1-0ubuntu0.18.04.2, but that force-defining was
  (correctly) reverted in the latest version 2.4.3-1ubuntu3.18.04.2.

  On arm64, __NR__sysctl is not defined, so the build now fails, e.g.:
  https://launchpadlibrarian.net/486997294/buildlog_ubuntu-bionic-arm64.systemd_237-3ubuntu10.42~202007031245~ubuntu18.04.1_BUILDING.txt.gz

  ../src/test/test-seccomp.c: In function ‘test_protect_sysctl’:
  ../src/test/test-seccomp.c:251:5: error: "__NR__sysctl" is not defined, evaluates to 0 [-Werror=undef]
   #if __NR__sysctl > 0
       ^~~~~~~~~~~~

  [test case]

  build systemd on bionic with latest packages (i.e. with latest
  libseccomp2 package)

  [regression potential]

  this adds a defined() check before comparing the __NR__sysctl value,
  so any regression would be limited to the specific function
  test_protect_sysctl() which is part of the test framework, thus
  leading to a failed build or incorrectly passed/failed test.

  [scope]

  this is needed only in Bionic.

  This is fixed upstream by commit
  4df8fe8415eaf4abd5b93c3447452547c6ea9e5f which is included in v244 and
  later, so this is fixed already for Focal and later.

To manage notifications about this bug go to:
https://bugs.launchpad.net/systemd/+bug/1886197/+subscriptions