[Bug 1901627] Please test proposed package

[Timo Aaltonen]

Hello Chad, or anyone else affected,

Accepted update-notifier into xenial-proposed. The package will build
now and be available at https://launchpad.net/ubuntu/+source/update-
notifier/3.168.13 in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
xenial to verification-done-xenial. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-xenial. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-notifier in Ubuntu.
https://bugs.launchpad.net/bugs/1901627

Title:
  Update product naming: Simplify UA Infrastructure ESM to UA Infra: ESM

Status in update-notifier package in Ubuntu:
  Fix Released
Status in update-notifier source package in Xenial:
  Fix Committed
Status in update-notifier source package in Bionic:
  Fix Committed
Status in update-notifier source package in Focal:
  Fix Committed
Status in update-notifier source package in Groovy:
  Fix Committed

Bug description:
  [Impact]

   The product names and product URLs of Ubuntu Advantage Extended
  Security Maintenance offerings have been rebranded prior to an
  official launch of the product ESM product in Ubuntu Xenial, Bionic
  and Focal. MOTD messages reference the old product name UA
  Infrastructure: Extended Security Maintenance as well as an invalid
  product URL https://ubuntu.com/esm.

  Correct both the product name "UA Infra: ESM" and the apt URL message
  See https://ubuntu.com/security/esm.

  Because these text messages are translated using gettext, translations
  will need to be updated as well.

  [Test Case]

   * Install unreleased ubuntu-advantage-tools from a PPA
   * Run: ua enable <yourToken> to activate UA apt repositories
   * Check MOTD messaging related to UA Infra: ESM prior to upgrade to -proposed update-notifier via /usr/lib/update-notifier/apt-check --human-readable

   * Upgrade update-notifier to -proposed
   * Re-check MOTD messaging related to UA Infra: ESM to see expected messages (not on groovy as there are no esm repos)

  #!/bin/bash
  #
  # SRU Verification update-notifier + ubuntu=advantage-tools
  # Test procedure:
  # - launch container Trusty, Xenial or Bionic
  # - Install ubuntu-advantage-tools from https://launchpad.net/~ua-client/+archive/ubuntu/proposed which supports esm on trusty, xenial, bionic, and focal
  # - Attach container to UA subscription (which activates the ESM APT repos
  # - run apt_check --human-readable to assert ESM pkg counts ARE NOT reported
  # - Upgrade update-notifier to -proposed
  # - re-run apt_check --human-readable to assert ESM pkg counts ARE reported

  set -e
  UA_TOKEN=$1
  if [ -z "$1" ]; then
   echo "Usage: $0 <contractTOKEN>"
   exit 1
  fi

  cat > test-un.yaml <<EOF
  #cloud-config
  ssh_import_id: [chad.smith]
  package_update: true
  package_upgrade: true
  apt:
    sources:
        ua.proposed:
            source: deb http://ppa.launchpad.net/ua-client/staging/ubuntu \$RELEASE main
            keyid: 6E34E7116C0BC933
  EOF

  cat > setup_proposed.sh <<EOF
  #/bin/bash
  mirror=http://archive.ubuntu.com/ubuntu
  echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
  apt-get update -q
  apt-get install -qy update-notifier-common
  EOF

  wait_for_boot() {
    local vm=$1 release=$2
    echo "--- Wait for cloud-init to finish"
    sleep 5
      lxc exec ${vm} -- cloud-init status --wait --long
  }

  for release in groovy; do
    echo "--- BEGIN $release update-notifier testing"
    vm=test-sru-$release
    echo "--- Launch cloud-init with ppa:ua-client/proposed enabled"
    lxc launch ubuntu-daily:${release} ${vm} -c user.user-data="$(cat test-un.yaml)"
    wait_for_boot ${vm} ${release}
    echo "--- Attach Ubuntu-Advantage, enabling services"
    lxc exec ${vm} -- ua attach ${UA_TOKEN}
    case "$release" in
          xenial) downrev_pkg="libkrad0=1.13.2+dfsg-5";;
          bionic) downrev_pkg="libkrad0=1.16-2build1";;
          focal) downrev_pkg="hello=2.10-2ubuntu2";;
          groovy) downrev_pkg="apport-retrace=2.20.11-0ubuntu50";;
    esac
    echo "-- Downgrading esm package to stable ubuntu release ver $downrev_pkg"
    lxc exec ${vm} -- apt-get install $downrev_pkg --yes
    lxc exec ${vm} -- dpkg-query --show update-notifier
    lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
    if [ "$release" = "groovy" ]; then
        UPGRADE_MATCH="1 of these updates is a security update"
        echo "Expect 1 upgradable package due to downgrade of non-esm pkg $downrev_pkg"
    else
        UPGRADE_MATCH="0 of these updates are security updates"
        UPGRADE_COUNT=0
         
      echo "--- Expect 0 upgradable packages for MOTD from apt_check before upgrade"
    fi
     lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
     lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep "${UPGRADE_MATCH}" && echo "SUCCESS: found ${UPGRADE_COUNT} security updates pre-upgrade" || echo "FAILURE: did not find expected ${UPGRADE_COUNT} ESM security updates"
    echo "--- Upgrade update-notifier from -proposed"
    lxc file push setup_proposed.sh ${vm}/
    lxc exec ${vm} -- bash /setup_proposed.sh | grep update-notifier
    lxc exec ${vm} -- dpkg-query --show update-notifier
    echo "--- Expect non-zero upgradable packages for MOTD from apt_check AFTER upgrade"
    lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
    lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '1 of these updates is a security update' && echo "SUCCESS: found 1 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 1 ESM security updates"
  done

  [Where problems could occur]

   *  Low risk:
      pep8 lint fixes plus MOTD text changes here. Minor logic changes in supplemental MOTD messaging for a product (ESM) that is not yet released and active in the wild on Xenial -> Focal. If messaging falls over the result is a lack of MOTD information about ESM package updates in motd, which is not yet released. If we can ensure we receive MOTD messaging about both ESM and non-ESM package updates without error, then risk of regression is minimal.

  [Other Info]

  [Original Description]

  MOTD text should align with the messaging that is being surfaced by
  ubuntu-advantage-tools and apt command line hook messaging.

  Current ESM product name is represented in MOTD as the following when
  logging into a VM:

  ### Current ESM-relatedMOTD messaging

  # When ESM is disabled:
  UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.

  Enable UA Infrastructure ESM to receive 14 additional security
  updates.

  # When ESM is enabled:
  UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.

  14 of these updates are provided through UA Infrastructure ESM.

  #### Expected new ESM messaging:
  # When ESM is disabled:
  UA Infra: Extended Security Maintenance \(ESM\) is not enabled.

  Enable UA Infra: ESM to receive 14 additional security updates.

  # When ESM is enabled:
  UA Infra: Extended Security Maintenance \(ESM\) is enabled.

  14 of these updates are provided through UA Infrastructure

  UA Infra: Extended Security Maintenance \(ESM\) is not enabled.

  Enable UA Infra: ESM to receive 14 additional security updates.

  This request for product naming changes and standardization is also
  represented as a request against UA-Client tooling/apt-hooks/status
  messaging.

  https://github.com/canonical/ubuntu-advantage-
  client/issues/1212#issuecomment-713735291

  Additionally documentation URLs for esm are updated from
  ubuntu.com/esm -> ubuntu.com/security/esm.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1901627/+subscriptions