[Bug 1822340] Re: [UIFe] motd messaging rewrite

[Chad Smith]

Marking this bug as verification failed because both Xenial and Bionic
introduced autopkgtest failures due to a new pep8 linting test that was
included.

Decided to reject Focal as well even though verification tests passed
because we have an APT URL fix that still needs to SRU into Focal and we
don't want to force 2 SRUs for Focal if we can combine the changeset
into a single SRU.

./tmp/autopkgtest.wN63go/build.IFg/src/tests/../data/apt_check.py:157:21:
W503 line break before binary operator ....

Rejecting:

xenial: update-notifier/3.168.11
   - autopkg logs: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz

bionic: update-notifier/3.192.1.8
    - autopkg failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-notifier/20201016_045656_8c126@/log.gz

focal: update-notifier/3.192.30.1
  - rejected to reduce SRU thrashing because a followup will be provided today.


** Tags removed: verification-needed verification-needed-bionic verification-needed-xenial
** Tags added: verification-failed verification-failed-bionic verification-failed-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to update-notifier in Ubuntu.
https://bugs.launchpad.net/bugs/1822340

Title:
  [UIFe] motd messaging rewrite

Status in update-notifier package in Ubuntu:
  Fix Released
Status in update-notifier source package in Trusty:
  Fix Released
Status in update-notifier source package in Xenial:
  Fix Committed
Status in update-notifier source package in Bionic:
  Fix Committed

Bug description:
  [Impact]
  Changes to the motd and update counting to count ESM security upgrades as security upgrades, and show some information about ESM upgrades.

  [Test case]
  The motd output has unit tests for the various combinations, passing counts of various upgrade types. That said, the actual counting might be wrong.

  The regression potential is higher in releases with ESM, as they'll
  get more messages and have more stuff that could go wrong.

  
  #!/bin/bash

  #
  # SRU Verification update-notifier + ubuntu=advantage-tools
  # Test procedure:
  # - launch container Trusty, Xenial or Bionic
  # - Install ubuntu-advantage-tools from https://launchpad.net/~ua-client/+archive/ubuntu/proposed which supports esm on trusty, xenial, bionic, and focal
  # - Attach container to UA subscription (which activates the ESM APT repos
  # - run apt_check --human-readable to assert ESM pkg counts ARE NOT reported
  # - Upgrade update-notifier to -proposed
  # - re-run apt_check --human-readable to assert ESM pkg counts ARE reported

  set -e
  UA_TOKEN=$1
  if [ -z "$1" ]; then
   echo "Usage: $0 <contractTOKEN>"
   exit 1
  fi
  # sources:
  #   ua.proposed:
  #      source: deb http://ppa.launchpad.net/canonical-server/ua-client-daily/ubuntu \$RELEASE main
  #      keyid: 94E187AD53A59D1847E4880F8A295C4FB8B190B7

  cat > test-uru.yaml <<EOF
  #cloud-config
  ssh_import_id: [chad.smith]
  package_update: true
  package_upgrade: true
  apt:
    sources:
        ua.proposed: deb http://ppa.launchpad.net/ua-client/proposed/ubuntu \$RELEASE main
        keyid: 6E34E7116C0BC933
  EOF


  
  cat > setup_proposed.sh <<EOF                                                   
  #/bin/bash                                                                      
  mirror=http://archive.ubuntu.com/ubuntu                                         
  echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
  apt-get update -q                                                               
  apt-get install -qy update-notifier
  EOF   

  wait_for_boot() {
    local vm=$1 release=$2
    echo "--- Wait for cloud-init to finish"
    sleep 5
      lxc exec ${vm} -- cloud-init status --wait --long                           
  }

  for release in xenial bionic focal; do
    echo "--- BEGIN $release update-notifier testing"
    vm=test-sru-$release
    echo "--- Launch cloud-init with ppa:ua-client/proposed enabled"
    lxc launch ubuntu-daily:${release} ${vm} -c user.user-data="$(cat test-un.yaml)"
    wait_for_boot ${vm} ${release}
    echo "--- Attach Ubuntu-Advantage, enabling services"
    lxc exec ${vm} -- ua attach ${UA_TOKEN}
    echo "--- Check Original MOTD output from apt_check before upgrade"
    lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
    echo "--- Upgrade update-notifier from -proposed"
    lxc file push setup_proposed.sh ${vm}/
    lxc exec ${vm} -- bash /setup-proposed.sh | grep update-notifier
    echo "--- Check upadate-notifier(-proposed) MOTD output from apt_check after upgrade"
    lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
  done

  
  [Regression potential]
  Potentially wrong reporting, lost translations.

  [disco UIFe]
  https://lists.ubuntu.com/archives/ubuntu-translators/2019-April/007534.html
  ubuntu-doc held for moderation

  [SRU]
  We're only SRUing this to trusty, as xenial and bionic will have some more changes, and it would just be a waste of time to SRU the trusty one there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1822340/+subscriptions