[Bug 1889449] Re: 18.04 to 20.04.1 upgrade on raspberry pi removes too many kernel meta packages

[Brian Murray]

** Description changed:

+ Test Case
+ ---------
+ 1) On a Raspberry Pi running the 18.04 LTS image run "do-release-upgrade -d"
+ 2) Once the upgrade completes observe that linux-raspi and linux-headers-raspi are offered for removal. (You'll see this when asked about removing obsolete packages.)
+ 
+ With the version of the dist-upgrader from -proposed (which you'll need
+ to manually download, unpack, and run) you'll notice that linux-raspi
+ and linux-headers-raspi are still installed after the upgrade completes.
+ 
+ Regression Potential
+ --------------------
+ The distribution upgrade code is now just not considering some additional packages for removal. This is a safe operation and if there was a regression it would be in poorly written python code which could cause a Traceback. So examine the actual change carefully.
+ 
+ Original Description
+ -------------------
  In a raspberry pi system running 18.04, when running "do-release-upgrade -d" to upgrade to 20.04.1,
  the transition from linux-raspi2-hwe-18.04 to linux-raspi doesn't seem to be done correctly and the system ends up without this and the linux-headers-raspi meta packages.
  
  These are the meta packages installed before the release upgrade:
  
  ii  linux-headers-raspi2-hwe-18.04      5.3.0.1017.6                        arm64        Linux kernel headers for Raspberry Pi systems.
  ii  linux-image-raspi2-hwe-18.04        5.3.0.1017.6                        arm64        Linux kernel image for Raspberry Pi systems.
  ii  linux-raspi2-hwe-18.04              5.3.0.1017.6                        arm64        Complete Linux kernel for Raspberry Pi systems.
  
  After the upgrade is complete this is the only kernel meta installed:
  
  ii  linux-image-raspi               5.4.0.1015.50
  arm64        Raspberry Pi Linux kernel image
  
  During the upgrade, these kernel packages update are made:
  
  Selecting previously unselected package linux-raspi-headers-5.4.0-1015.
  Preparing to unpack .../244-linux-raspi-headers-5.4.0-1015_5.4.0-1015.15_arm64.deb ...
  Unpacking linux-raspi-headers-5.4.0-1015 (5.4.0-1015.15) ...
  Selecting previously unselected package linux-headers-5.4.0-1015-raspi.
  Preparing to unpack .../245-linux-headers-5.4.0-1015-raspi_5.4.0-1015.15_arm64.deb ...
  Unpacking linux-headers-5.4.0-1015-raspi (5.4.0-1015.15) ...
  Selecting previously unselected package linux-headers-raspi.
  Preparing to unpack .../246-linux-headers-raspi_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-headers-raspi (5.4.0.1015.50) ...
  Selecting previously unselected package linux-modules-5.4.0-1015-raspi.
  Preparing to unpack .../247-linux-modules-5.4.0-1015-raspi_5.4.0-1015.15_arm64.deb ...
  Unpacking linux-modules-5.4.0-1015-raspi (5.4.0-1015.15) ...
  Selecting previously unselected package linux-image-5.4.0-1015-raspi.
  Preparing to unpack .../248-linux-image-5.4.0-1015-raspi_5.4.0-1015.15_arm64.deb ...
  Unpacking linux-image-5.4.0-1015-raspi (5.4.0-1015.15) ...
  Selecting previously unselected package linux-image-raspi.
  Preparing to unpack .../249-linux-image-raspi_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-image-raspi (5.4.0.1015.50) ...
  Selecting previously unselected package linux-raspi.
  Preparing to unpack .../250-linux-raspi_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-raspi (5.4.0.1015.50) ...
  Preparing to unpack .../251-linux-raspi2-hwe-18.04_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-raspi2-hwe-18.04 (5.4.0.1015.50) over (5.3.0.1030.20) ...
  Preparing to unpack .../252-linux-headers-raspi2-hwe-18.04_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-headers-raspi2-hwe-18.04 (5.4.0.1015.50) over (5.3.0.1030.20) ...
  Preparing to unpack .../253-linux-image-raspi2-hwe-18.04_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-image-raspi2-hwe-18.04 (5.4.0.1015.50) over (5.3.0.1030.20) ...
  
+ At the end of the upgrade process, do-release-upgrade calculates the
+ obsolete packages and remove the following kernel packages:
  
- At the end of the upgrade process, do-release-upgrade calculates the obsolete packages and remove the following kernel packages:
- 
-   linux-headers-5.3.0-1017-raspi2 
-   linux-headers-5.3.0-1030-raspi2 linux-headers-5.4.0-1015-raspi 
-   linux-headers-raspi linux-headers-raspi2-hwe-18.04 
-   linux-image-5.3.0-1017-raspi2 linux-image-raspi2-hwe-18.04 
-   linux-modules-5.3.0-1017-raspi2 linux-raspi 
-   linux-raspi-headers-5.4.0-1015 linux-raspi2-5.3-headers-5.3.0-1017 
-   linux-raspi2-5.3-headers-5.3.0-1030 linux-raspi2-hwe-18.04 
+   linux-headers-5.3.0-1017-raspi2
+   linux-headers-5.3.0-1030-raspi2 linux-headers-5.4.0-1015-raspi
+   linux-headers-raspi linux-headers-raspi2-hwe-18.04
+   linux-image-5.3.0-1017-raspi2 linux-image-raspi2-hwe-18.04
+   linux-modules-5.3.0-1017-raspi2 linux-raspi
+   linux-raspi-headers-5.4.0-1015 linux-raspi2-5.3-headers-5.3.0-1017
+   linux-raspi2-5.3-headers-5.3.0-1030 linux-raspi2-hwe-18.04
  
  Please note that the flavour of the raspberry pi kernel changed from
  "raspi2" on 18.04 to "raspi" on 20.04. The transitional packages in
  20.04 seem to be correct, so this behaviour is likely an issue with do-
  release-upgrade not handling this rename correctly and removing too many
  packages.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1889449

Title:
  18.04 to 20.04.1 upgrade on raspberry pi removes too many kernel meta
  packages

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Focal:
  In Progress

Bug description:
  Test Case
  ---------
  1) On a Raspberry Pi running the 18.04 LTS image run "do-release-upgrade -d"
  2) Once the upgrade completes observe that linux-raspi and linux-headers-raspi are offered for removal. (You'll see this when asked about removing obsolete packages.)

  With the version of the dist-upgrader from -proposed (which you'll
  need to manually download, unpack, and run) you'll notice that linux-
  raspi and linux-headers-raspi are still installed after the upgrade
  completes.

  Regression Potential
  --------------------
  The distribution upgrade code is now just not considering some additional packages for removal. This is a safe operation and if there was a regression it would be in poorly written python code which could cause a Traceback. So examine the actual change carefully.

  Original Description
  -------------------
  In a raspberry pi system running 18.04, when running "do-release-upgrade -d" to upgrade to 20.04.1,
  the transition from linux-raspi2-hwe-18.04 to linux-raspi doesn't seem to be done correctly and the system ends up without this and the linux-headers-raspi meta packages.

  These are the meta packages installed before the release upgrade:

  ii  linux-headers-raspi2-hwe-18.04      5.3.0.1017.6                        arm64        Linux kernel headers for Raspberry Pi systems.
  ii  linux-image-raspi2-hwe-18.04        5.3.0.1017.6                        arm64        Linux kernel image for Raspberry Pi systems.
  ii  linux-raspi2-hwe-18.04              5.3.0.1017.6                        arm64        Complete Linux kernel for Raspberry Pi systems.

  After the upgrade is complete this is the only kernel meta installed:

  ii  linux-image-raspi               5.4.0.1015.50
  arm64        Raspberry Pi Linux kernel image

  During the upgrade, these kernel packages update are made:

  Selecting previously unselected package linux-raspi-headers-5.4.0-1015.
  Preparing to unpack .../244-linux-raspi-headers-5.4.0-1015_5.4.0-1015.15_arm64.deb ...
  Unpacking linux-raspi-headers-5.4.0-1015 (5.4.0-1015.15) ...
  Selecting previously unselected package linux-headers-5.4.0-1015-raspi.
  Preparing to unpack .../245-linux-headers-5.4.0-1015-raspi_5.4.0-1015.15_arm64.deb ...
  Unpacking linux-headers-5.4.0-1015-raspi (5.4.0-1015.15) ...
  Selecting previously unselected package linux-headers-raspi.
  Preparing to unpack .../246-linux-headers-raspi_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-headers-raspi (5.4.0.1015.50) ...
  Selecting previously unselected package linux-modules-5.4.0-1015-raspi.
  Preparing to unpack .../247-linux-modules-5.4.0-1015-raspi_5.4.0-1015.15_arm64.deb ...
  Unpacking linux-modules-5.4.0-1015-raspi (5.4.0-1015.15) ...
  Selecting previously unselected package linux-image-5.4.0-1015-raspi.
  Preparing to unpack .../248-linux-image-5.4.0-1015-raspi_5.4.0-1015.15_arm64.deb ...
  Unpacking linux-image-5.4.0-1015-raspi (5.4.0-1015.15) ...
  Selecting previously unselected package linux-image-raspi.
  Preparing to unpack .../249-linux-image-raspi_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-image-raspi (5.4.0.1015.50) ...
  Selecting previously unselected package linux-raspi.
  Preparing to unpack .../250-linux-raspi_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-raspi (5.4.0.1015.50) ...
  Preparing to unpack .../251-linux-raspi2-hwe-18.04_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-raspi2-hwe-18.04 (5.4.0.1015.50) over (5.3.0.1030.20) ...
  Preparing to unpack .../252-linux-headers-raspi2-hwe-18.04_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-headers-raspi2-hwe-18.04 (5.4.0.1015.50) over (5.3.0.1030.20) ...
  Preparing to unpack .../253-linux-image-raspi2-hwe-18.04_5.4.0.1015.50_arm64.deb ...
  Unpacking linux-image-raspi2-hwe-18.04 (5.4.0.1015.50) over (5.3.0.1030.20) ...

  At the end of the upgrade process, do-release-upgrade calculates the
  obsolete packages and remove the following kernel packages:

    linux-headers-5.3.0-1017-raspi2
    linux-headers-5.3.0-1030-raspi2 linux-headers-5.4.0-1015-raspi
    linux-headers-raspi linux-headers-raspi2-hwe-18.04
    linux-image-5.3.0-1017-raspi2 linux-image-raspi2-hwe-18.04
    linux-modules-5.3.0-1017-raspi2 linux-raspi
    linux-raspi-headers-5.4.0-1015 linux-raspi2-5.3-headers-5.3.0-1017
    linux-raspi2-5.3-headers-5.3.0-1030 linux-raspi2-hwe-18.04

  Please note that the flavour of the raspberry pi kernel changed from
  "raspi2" on 18.04 to "raspi" on 20.04. The transitional packages in
  20.04 seem to be correct, so this behaviour is likely an issue with
  do-release-upgrade not handling this rename correctly and removing too
  many packages.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1889449/+subscriptions