[Bug 1873031] Re: 245.4-2ubuntu1 has broken dhcp based NTP updates

[Balint Reczey]

Forwarded the systemd part: https://salsa.debian.org/systemd-
team/systemd/-/merge_requests/89

The systemd part only emits an error from the dhclient hook, thus the DHCP based NTP updates are not broken.
I'll fix systemd in the next update after Focal's release.

** Changed in: systemd (Ubuntu Bionic)
       Status: New => Invalid

** Changed in: systemd (Ubuntu Eoan)
       Status: New => Invalid

** Changed in: systemd (Ubuntu)
       Status: New => In Progress

** Changed in: systemd (Ubuntu)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1873031

Title:
  245.4-2ubuntu1 has broken dhcp based NTP updates

Status in chrony package in Ubuntu:
  Fix Released
Status in systemd package in Ubuntu:
  In Progress
Status in chrony source package in Bionic:
  New
Status in systemd source package in Bionic:
  Invalid
Status in chrony source package in Eoan:
  New
Status in systemd source package in Eoan:
  Invalid

Bug description:
  systemd has broken this by the split of timesyncd.

  On a system that installed chrony (or other NTP servers) you'll have:

  Desired=Unknown/Install/Remove/Purge/Hold
  | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
  |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
  ||/ Name              Version        Architecture Description
  +++-=================-==============-============-===============================================================
  ii  chrony            3.5-6ubuntu3   amd64        Versatile implementation of the Network Time Protocol
  rc  systemd-timesyncd 245.4-4ubuntu1 amd64        minimalistic service to synchronize local time with NTP servers

  That left this behind:
    /etc/dhcp/dhclient-exit-hooks.d/timesyncd

  And if you now run a dhcp based time server push it will fail very
  badly.

  P.S. This is triggered by the chrony autopkgtests but not an issue in chrony yet it is in systemd.
  But due to that one can use [1] as easy reproducer, I wonder how systemd slipped by this issue in autopkgtest?

  It contains:
          systemctl try-restart systemd-timesyncd.service || true

  Which in the setup the system now has will trigger:
   sudo dhclient dummy0
  Failed to try-restart systemd-timesyncd.service: Unit systemd-timesyncd.service is masked.

  P.S. I'll harden the chrony test to not stumble over this but it
  should be revisited for systemd to provide a better fix than causing
  this message every time (maybe pre-check if it is enabled and
  unmasked)?

  [1]: https://git.launchpad.net/ubuntu/+source/chrony/tree/debian/tests
  /time-sources-from-dhcp-servers?h=ubuntu/focal-devel

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chrony/+bug/1873031/+subscriptions