[Bug 1872551] Re: software-properties-qt: nvidia driver version switch fails

[Hans P. Möller]

could you test adding this to /lib/python3/dist-
packages/softwareproperties/qt/SoftwarePropertiesQt.py
SoftwarePropertiesQt.py ? For me testing with nvidia is not easy

--- /lib/python3/dist-packages/softwareproperties/qt/SoftwarePropertiesQt.py	2020-04-14 09:16:19.370592334 -0400
+++ SoftwarePropertiesQt.py	2020-04-14 09:02:21.894527421 -0400
@@ -78,6 +78,17 @@
       QWidget.__init__(self)
       uic.loadUi("%s/designer/main.ui" % datadir, self)
 
+def get_dependencies(apt_cache, package_name, pattern=None):
+    """ Get the package dependencies, which can be filtered out by a pattern """
+    dependencies = []
+    for or_group in apt_cache[package_name].candidate.dependencies:
+        for dep in or_group:
+            if dep.rawtype in ["Depends", "PreDepends"]:
+                dependencies.append(dep.name)
+    if pattern:
+        dependencies = [ x for x in dependencies if x.find(pattern) != -1 ]
+    return dependencies
+
 class SoftwarePropertiesQt(SoftwareProperties):
   def __init__(self, datadir=None, options=None, parent=None, file=None, attachWinID=None):
     """ Provide a Qt-based graphical user interface to configure

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/1872551

Title:
  software-properties-qt: nvidia driver version switch fails

Status in software-properties package in Ubuntu:
  Confirmed

Bug description:
  Switching the Nvidia driver version with kubuntu-driver-manager
  doesn't work anymore: Selecting a different driver version (nvidia-
  driver-440 instead of the currently selected / installed -390) and
  clicking "Apply Changes" has no effect and produces this error message
  in the terminal:

    Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/softwareproperties/qt/SoftwarePropertiesQt.py", line 895, in on_driver_changes_apply
      for dep in get_dependencies(self.apt_cache, pkg.shortname, 'nvidia'):
  NameError: name 'get_dependencies' is not defined

  Steps to reproduce:
  - sudo kubuntu-driver-manager
  - Under "Additional Drivers", select a different Nvidia driver version
    (in my case: 440 instead of 390)
  - Click "Apply Changes"
  - (observe error message in the terminal)

  Expected result:
  - No error message
  - Nvidia driver version 440 gets installed

  Actual result:
  - Error message
  - No change in the installed Nvidia driver version

  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: kubuntu-driver-manager (not installed)
  ProcVersionSignature: Ubuntu 5.4.0-21.25-generic 5.4.27
  Uname: Linux 5.4.0-21-generic x86_64
  ApportVersion: 2.20.11-0ubuntu26
  Architecture: amd64
  CasperMD5CheckResult: skip
  CurrentDesktop: KDE
  Date: Mon Apr 13 23:41:56 2020
  InstallationDate: Installed on 2016-11-26 (1234 days ago)
  InstallationMedia: Kubuntu 16.10 "Yakkety Yak" - Release amd64 (20161012.1)
  SourcePackage: kubuntu-driver-manager
  UpgradeStatus: Upgraded to focal on 2020-03-06 (38 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1872551/+subscriptions