[Bug 1776626] Re: [18.10 FEAT] Support 4k sectors for fast clear key dm-crypt - crypttab part

[Balint Reczey]

Verified with systemd/237-3ubuntu10.31:

ubuntu at ubuntu-Standard-PC-i440FX-PIIX-1996:~$ sudo vi /etc/crypttab
ubuntu at ubuntu-Standard-PC-i440FX-PIIX-1996:~$ sudo systemctl daemon-reload
ubuntu at ubuntu-Standard-PC-i440FX-PIIX-1996:~$ sudo service systemd-cryptsetup at vdb_crypt start
Please enter passphrase for disk vdb_crypt! ****
ubuntu at ubuntu-Standard-PC-i440FX-PIIX-1996:~$ cat /etc/crypttab 
vdb_crypt /dev/vdb none luks,sector-size=4096

ubuntu at ubuntu-Standard-PC-i440FX-PIIX-1996:~$ sudo service systemd-cryptsetup at vdb_crypt status
● systemd-cryptsetup at vdb_crypt.service - Cryptography Setup for vdb_crypt
   Loaded: loaded (/etc/crypttab; generated)
   Active: active (exited) since Tue 2019-10-08 21:05:11 CEST; 13s ago
     Docs: man:crypttab(5)
           man:systemd-cryptsetup-generator(8)
           man:systemd-cryptsetup at .service(8)
  Process: 1999 ExecStart=/lib/systemd/systemd-cryptsetup attach vdb_crypt /dev/vdb none luks,sector-size=4096 (cod
 Main PID: 1999 (code=exited, status=0/SUCCESS)

okt 08 21:05:06 ubuntu-Standard-PC-i440FX-PIIX-1996 systemd[1]: Starting Cryptography Setup for vdb_crypt...
okt 08 21:05:09 ubuntu-Standard-PC-i440FX-PIIX-1996 systemd-cryptsetup[1999]: Set cipher aes, mode xts-plain64, key
okt 08 21:05:11 ubuntu-Standard-PC-i440FX-PIIX-1996 systemd[1]: Started Cryptography Setup for vdb_crypt.
ubuntu at ubuntu-Standard-PC-i440FX-PIIX-1996:~$ sudo fdisk /dev/mapper/vdb_crypt 

Welcome to fdisk (util-linux 2.31.1).
Changes will remain in memory only, until you decide to write them.
Be careful before using the write command.

Device does not contain a recognized partition table.
Created a new DOS disklabel with disk identifier 0x313e0336.

Command (m for help): p
Disk /dev/mapper/vdb_crypt: 5 GiB, 5366611968 bytes, 1310208 sectors
Units: sectors of 1 * 4096 = 4096 bytes
Sector size (logical/physical): 4096 bytes / 4096 bytes
I/O size (minimum/optimal): 4096 bytes / 4096 bytes
Disklabel type: dos
Disk identifier: 0x313e0336

Command (m for help): q

ubuntu at ubuntu-Standard-PC-i440FX-PIIX-1996:~$


** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to cryptsetup in Ubuntu.
https://bugs.launchpad.net/bugs/1776626

Title:
  [18.10 FEAT] Support 4k sectors for fast clear key dm-crypt - crypttab
  part

Status in Ubuntu on IBM z Systems:
  Fix Released
Status in cryptsetup package in Ubuntu:
  Fix Released
Status in systemd package in Ubuntu:
  Fix Released
Status in cryptsetup source package in Bionic:
  Won't Fix
Status in systemd source package in Bionic:
  Fix Committed

Bug description:
  [Impact]

   * cryptsetup in bionic supports creating luks volumes with a non-
  standard sector-size option, and thus this option also needs to be
  used when activating the LUKS volumes. Add sector-size= option support
  to /etc/crypttab.

  [Test Case]

   * Create a plain LUKS volume with sector-size 4096
   * Specify sector-size=4096 option in /etc/crypttab
   * reload systemd, start systemd-cryptsetup at .service for that volume
   * check the journal, to ensure that `sector-size` option was recognized and is active. (i.e. there is not error messages about unrecognized option `sector-size` from systemd-cryptsetup)

  [Regression Potential]

   * This is an optional argument, not used by default. Currently custom
  sector-size crypttab does not work correctly, and thus cannot regress.

  [Other Info]
   
   * Original bug report

  Support fast clear key dm-crypt with 4k support

  Extend /etc/crypttab  to enable 4k sector support in plain mode

  The proposed enhancements are posted on github, see
       https://github.com/systemd/systemd/issues/8881

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1776626/+subscriptions