[Bug 1840640] Re: sync_file_range fails in nspawn containers on arm, ppc
Launchpad Bug Tracker
1840640 at bugs.launchpad.net
Tue Nov 26 17:37:57 UTC 2019
This bug was fixed in the package systemd - 237-3ubuntu10.33
---------------
systemd (237-3ubuntu10.33) bionic; urgency=medium
* d/p/lp1852754/0001-network-do-not-re-set-MTU-when-current-and-requested.patch,
d/p/lp1852754/0002-network-call-link_acquire_conf-and-link_enter_join_n.patch,
d/p/lp1852754/0003-network-prohibit-to-set-MTUBytes-and-UseMTU-simultan.patch:
- Complete link setup after setting mtu (LP: #1852754)
systemd (237-3ubuntu10.32) bionic; urgency=medium
[ Victor Tapia ]
* d/p/resolved_disable-connection-downgrade-when-DNSSEC-yes.patch
Fix regression introduced by
resolved-Mitigate-DVE-2018-0001-by-retrying-NXDOMAIN-with.patch when
DNSSEC=yes (LP: #1796501)
[ Dan Streetman ]
* d/p/fix-typo-lp1668771-resolved-switch-cache-option-to-a-tri-state-option-s.patch:
- Fix typo in previous patch
* d/p/lp1840640-shared-seccomp-add-sync_file_range2.patch:
- allow sync_file_range2 in nspawn container
(LP: #1840640)
* d/p/lp1783994-dissect-Don-t-count-RPMB-and-boot-partitions-8609.patch:
- avoid systemd-gpt-auto-generator failure if mmc dev present
(LP: #1783994)
* d/p/lp1832672-resolved-rework-parsing-of-etc-hosts.patch:
- do not fail entire file on error when parsing /etc/hosts
- parse # char anywhere in line as start of comment
(LP: #1832672)
* d/p/lp1843381-dell_passthrough_skip_rename_retry.patch,
debian/extra/rules/73-usb-net-by-mac.rules:
- fix rename delay for systems using "Dell MAC passthrough"
(LP: #1843381)
* d/p/lp1849733/0001-resolved-longlived-TCP-connections.patch,
d/p/lp1849733/0002-resolved-line-split-dns_stream_new-function-signatur.patch,
d/p/lp1849733/0003-resolved-add-some-assert-s.patch,
d/p/lp1849733/0004-stream-track-type-of-DnsStream-object.patch,
d/p/lp1849733/0005-llmnr-add-comment-why-we-install-no-complete-handler.patch,
d/p/lp1849733/0006-resolved-restart-stream-timeout-whenever-we-managed-.patch,
d/p/lp1849733/0007-resolved-only-call-complete-with-zero-argument-in-LL.patch,
d/p/lp1849733/0008-resolved-add-comment-to-dns_stream_complete-about-it.patch,
d/p/lp1849733/0009-resolved-keep-stub-stream-connections-up-for-as-long.patch,
d/p/lp1849733/0010-resolved-if-we-can-t-append-EDNS-OPT-RR-then-indicat.patch,
d/p/lp1849733/0011-resolved-don-t-let-EDNS0-OPT-dgram-size-affect-TCP.patch,
d/p/lp1849733/0012-resolved-add-new-accessor-dns_stream_take_read_packe.patch,
d/p/lp1849733/0013-resolve-do-not-complete-stream-transaction-when-it-i.patch:
- add TCP pipelining to handle getaddrinfo() fallback to TCP
- ignore EDNS0 payload limit when responding over TCP (LP: #1849733)
* d/p/lp1849658-resolved-set-stream-type-during-DnsStream-creation.patch:
- Fix bug in refcounting TCP stream types (LP: #1849658)
* d/p/lp1850704/0001-networkd-Unify-set-MTU.patch,
d/p/lp1850704/0002-network-drop-redundant-lines.patch:
- Fix setting mtu if interface already up (LP: #1850704)
* d/extra/dhclient-enter-resolved-hook:
- only restart resolved if dhclient conf changed (LP: #1805183)
-- Dan Streetman <ddstreet at canonical.com> Fri, 15 Nov 2019 10:01:16
-0500
** Changed in: systemd (Ubuntu Bionic)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1840640
Title:
sync_file_range fails in nspawn containers on arm, ppc
Status in systemd package in Ubuntu:
Fix Released
Status in systemd source package in Bionic:
Fix Released
Status in systemd source package in Disco:
Fix Released
Bug description:
[impact]
calling the glibc function sync_file_range() on a armhf nspawn
container fails.
[test case]
see sample C program from original description below. compile and run
that inside a nspawn container on armhf and it will fail.
nspawn instructions:
sudo apt install debootstrap systemd-container
sudo -i
debootstrap --arch=armhf bionic ~/bionic-tree/
systemd-nspawn -D ~/bionic-tree/
[regression potential]
this only adjusts nspawn to allow the sync_file_range2 syscall which
is used on armhf, so the regression potential is very low. any
possible regressions would likely be when calling sync_file_range().
[other info]
original description:
---
ARM has two sync_file_range syscalls, sync_file_range and
sync_file_range2. The former is apparently not used, and glibc calls
the latter whenever a userspace program calls sync_file_range. I'm
guessing systemd-nspawn doesn't know this, because the follow code
consistently fails in an nspawn container on ARM:
#define _GNU_SOURCE
#include <fcntl.h>
#include <unistd.h>
#include <stdio.h>
#include <errno.h>
void main()
{
int f = open("/tmp/syncrange.test",O_CREAT|O_RDWR,0666);
int r=sync_file_range(f, 0, 0, 0);
if (r)
perror("sync_file_range");
close(f);
}
This seems to be causing problems specifically for borg(backup) and
postgres:
https://github.com/borgbackup/borg/issues/4710
https://www.postgresql.org/message-id/flat/CA%2BhUKG%2BydOUT4zjxb6QmJWy8U9WbC-q%2BJWV7wLsEY9Df%3Dmw0Mw%40mail.gmail.com#ac8f14897647dc7eae3c7e7cbed36d93
The solution should be to cherrypick
https://github.com/systemd/systemd/pull/13352, I am currently waiting
for systemd to rebuild on a slow ARM box. Any chance of an SRU?
ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: systemd-container 237-3ubuntu10.24
Uname: Linux 4.14.66+ armv7l
NonfreeKernelModules: extcon_usb_gpio
ApportVersion: 2.20.9-0ubuntu7.7
Architecture: armhf
Date: Mon Aug 19 11:10:48 2019
ProcEnviron:
TERM=screen
PATH=(custom, no user)
LANG=en_GB.UTF-8
SHELL=/bin/bash
SourcePackage: systemd
UpgradeStatus: No upgrade log present (probably fresh install)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1840640/+subscriptions
More information about the foundations-bugs
mailing list