[Bug 1848399] Re: update-grub fails if a pool fails to import

[Launchpad Bug Tracker]

This bug was fixed in the package grub2 - 2.04-1ubuntu14

---------------
grub2 (2.04-1ubuntu14) focal; urgency=medium

  * debian/patches/ubuntu-zfs-enhance-support.patch:
    - Handle the case where grub-probe returns several devices for a single
      pool (LP: #1848856). Thanks jpb for the report and the proposed patch.
    - Add savedefault to non-recovery entries (LP: #1850202). Thanks Deltik
      for the patch.
    - Do not crash on invalid fstab and report the invalid entry.
      (LP: #1849347) Thanks Deltik for the patch.
    - When a pool fails to import, catch and display the error message and
      continue with other pools. Import all the pools in readonly mode so we
      can import other pools with unsupported features (LP: #1848399) Thanks
      satmandu for the investigation and the proposed patch

 -- Jean-Baptiste Lallement <jean-baptiste.lallement at ubuntu.com>  Mon,
18 Nov 2019 11:22:43 +0100

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to grub2 in Ubuntu.
https://bugs.launchpad.net/bugs/1848399

Title:
  update-grub fails if a pool fails to import

Status in grub2 package in Ubuntu:
  Fix Released
Status in grubzfs-testsuite package in Ubuntu:
  Fix Released
Status in grub2 source package in Eoan:
  In Progress
Status in grubzfs-testsuite source package in Eoan:
  Triaged
Status in grub2 source package in Focal:
  Fix Released
Status in grubzfs-testsuite source package in Focal:
  Fix Released

Bug description:
  [Description] 
  If a pool to import update-grub will fail because the import error message is used as the name of the pool. The error is similar to:

  "cannot open 'This': no such pool" when no ZFS pools are available

  The error can be caused by anything such as an invalid feature or a
  corrupted device.

  The fix catches the error, displays it, ignore the pool but import
  others.

  [Test Case]
  1. Create a pool on a device and export it
  2. Corrupt the device for example by shuffling random blocks on the device but not the header so it is recognized as a ZFS device
  3. Run update-grub

  Expected result:
  The pool is ignored and reported

  Actual result:
  Generation of the grub menu fails

  
  [Regression potential]
  Low since currently the script aborts on error as soon as it fails to import. Worst case nothing imports and there is no zfs entries in the grub menu.

  
  ProblemType: Bug
  DistroRelease: Ubuntu 19.10
  Package: ubiquity 19.10.20
  ProcVersionSignature: Ubuntu 5.3.0-18.19-generic 5.3.1
  Uname: Linux 5.3.0-18-generic x86_64
  NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
  ApportVersion: 2.20.11-0ubuntu8
  Architecture: amd64
  CasperVersion: 1.425
  Date: Wed Oct 16 20:03:30 2019
  InstallCmdLine: BOOT_IMAGE=/casper/vmlinuz file=/cdrom/preseed/ubuntu.seed quiet splash ---
  LiveMediaBuild: Ubuntu 19.10 "Eoan Ermine" - Release amd64 (20191014)
  SourcePackage: ubiquity
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions