[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist

[Jean-Baptiste Lallement]

** Description changed:

- install from Oct 14 live installer failed.
+ [Description] 
+ If a pool to import update-grub will fail because the import error message is used as the name of the pool. The error is similar to:
+ 
+ "cannot open 'This': no such pool" when no ZFS pools are available
+ 
+ The error can be caused by anything such as an invalid feature or a
+ corrupted device.
+ 
+ The fix catches the error, displays it, ignore the pool but import
+ others.
+ 
+ [Test Case]
+ 1. Create a pool on a device and export it
+ 2. Corrupt the device for example by shuffling random blocks on the device but not the header so it is recognized as a ZFS device
+ 3. Run update-grub
+ 
+ Expected result:
+ The pool is ignored and reported
+ 
+ Actual result:
+ Generation of the grub menu fails
+ 
+ 
+ [Regression potential]
+ Low since currently the script aborts on error as soon as it fails to import. Worst case nothing imports and there is no zfs entries in the grub menu.
+ 
  
  ProblemType: Bug
  DistroRelease: Ubuntu 19.10
  Package: ubiquity 19.10.20
  ProcVersionSignature: Ubuntu 5.3.0-18.19-generic 5.3.1
  Uname: Linux 5.3.0-18-generic x86_64
  NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
  ApportVersion: 2.20.11-0ubuntu8
  Architecture: amd64
  CasperVersion: 1.425
  Date: Wed Oct 16 20:03:30 2019
  InstallCmdLine: BOOT_IMAGE=/casper/vmlinuz file=/cdrom/preseed/ubuntu.seed quiet splash ---
  LiveMediaBuild: Ubuntu 19.10 "Eoan Ermine" - Release amd64 (20191014)
  SourcePackage: ubiquity
  UpgradeStatus: No upgrade log present (probably fresh install)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to grub2 in Ubuntu.
https://bugs.launchpad.net/bugs/1848399

Title:
  update-grub fails if zpools with unsupported feature_flags exist

Status in grub2 package in Ubuntu:
  In Progress
Status in grubzfs-testsuite package in Ubuntu:
  Triaged
Status in grub2 source package in Eoan:
  In Progress
Status in grubzfs-testsuite source package in Eoan:
  Triaged
Status in grub2 source package in Focal:
  In Progress
Status in grubzfs-testsuite source package in Focal:
  Triaged

Bug description:
  [Description] 
  If a pool to import update-grub will fail because the import error message is used as the name of the pool. The error is similar to:

  "cannot open 'This': no such pool" when no ZFS pools are available

  The error can be caused by anything such as an invalid feature or a
  corrupted device.

  The fix catches the error, displays it, ignore the pool but import
  others.

  [Test Case]
  1. Create a pool on a device and export it
  2. Corrupt the device for example by shuffling random blocks on the device but not the header so it is recognized as a ZFS device
  3. Run update-grub

  Expected result:
  The pool is ignored and reported

  Actual result:
  Generation of the grub menu fails

  
  [Regression potential]
  Low since currently the script aborts on error as soon as it fails to import. Worst case nothing imports and there is no zfs entries in the grub menu.

  
  ProblemType: Bug
  DistroRelease: Ubuntu 19.10
  Package: ubiquity 19.10.20
  ProcVersionSignature: Ubuntu 5.3.0-18.19-generic 5.3.1
  Uname: Linux 5.3.0-18-generic x86_64
  NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
  ApportVersion: 2.20.11-0ubuntu8
  Architecture: amd64
  CasperVersion: 1.425
  Date: Wed Oct 16 20:03:30 2019
  InstallCmdLine: BOOT_IMAGE=/casper/vmlinuz file=/cdrom/preseed/ubuntu.seed quiet splash ---
  LiveMediaBuild: Ubuntu 19.10 "Eoan Ermine" - Release amd64 (20191014)
  SourcePackage: ubiquity
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions