[Bug 1852611] [NEW] update-grub fails because 10_linux_zfs puts a spare closed brace

[Luca Citi]

Public bug reported:

I have installed 19.10 on a zfs filesystem using the installer.
I have also installed zfs-auto-snapshot. Zsys is not installed.
When I run "update-grub", I get the error:

Adding boot menu entry for EFI firmware configuration
error: syntax error.
error: Incorrect command.
error: syntax error.
Syntax error at line 178

At that line the file contains an unmatched closed brace "}".

Looking at the code for /etc/grub.d/10_linux_zfs I think that the error
is caused by the line "at_least_one_entry=1" at row 864. Since the
"main" entry does not open an extra brace (unlike, "advanced" or
"history"), I don't think it should set the flag to trigger the addition
of the extra closed brace at line 942.

Commenting line 864 fixes the problem in my case.


=== Environment ===

$ lsb_release -rd
Description:	Ubuntu 19.10
Release:	19.10

$ apt-cache policy grub-common
grub-common:
  Installed: 2.04-1ubuntu12
  Candidate: 2.04-1ubuntu12
  Version table:
 *** 2.04-1ubuntu12 500
        500 http://gb.archive.ubuntu.com/ubuntu eoan/main amd64 Packages
        100 /var/lib/dpkg/status

** Affects: grub2 (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to grub2 in Ubuntu.
https://bugs.launchpad.net/bugs/1852611

Title:
  update-grub fails because 10_linux_zfs puts a spare closed brace

Status in grub2 package in Ubuntu:
  New

Bug description:
  I have installed 19.10 on a zfs filesystem using the installer.
  I have also installed zfs-auto-snapshot. Zsys is not installed.
  When I run "update-grub", I get the error:

  Adding boot menu entry for EFI firmware configuration
  error: syntax error.
  error: Incorrect command.
  error: syntax error.
  Syntax error at line 178

  At that line the file contains an unmatched closed brace "}".

  Looking at the code for /etc/grub.d/10_linux_zfs I think that the
  error is caused by the line "at_least_one_entry=1" at row 864. Since
  the "main" entry does not open an extra brace (unlike, "advanced" or
  "history"), I don't think it should set the flag to trigger the
  addition of the extra closed brace at line 942.

  Commenting line 864 fixes the problem in my case.

  
  === Environment ===

  $ lsb_release -rd
  Description:	Ubuntu 19.10
  Release:	19.10

  $ apt-cache policy grub-common
  grub-common:
    Installed: 2.04-1ubuntu12
    Candidate: 2.04-1ubuntu12
    Version table:
   *** 2.04-1ubuntu12 500
          500 http://gb.archive.ubuntu.com/ubuntu eoan/main amd64 Packages
          100 /var/lib/dpkg/status

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1852611/+subscriptions