[Bug 1849491] Re: Add support for EXTRA_SNAPS in bionic

[Łukasz Zemczak]

Just ran a livefs build of ubuntu-core bionic with an "extra_snaps":
["hello-world"] override - the build succeeded and the extra snap has
been pulled onto the image:

https://launchpadlibrarian.net/450308352
/buildlog_ubuntu_bionic_amd64_ubuntu-core_BUILDING.txt.gz

** Tags removed: verification-needed-bionic
** Tags added: verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to livecd-rootfs in Ubuntu.
https://bugs.launchpad.net/bugs/1849491

Title:
  Add support for EXTRA_SNAPS in bionic

Status in livecd-rootfs package in Ubuntu:
  Fix Released
Status in livecd-rootfs source package in Xenial:
  Fix Committed
Status in livecd-rootfs source package in Bionic:
  Fix Committed

Bug description:
  [Impact]

  Currently we are building core18 images using devel (eoan previously,
  now focal), but we need to switch to actually using bionic instead (as
  focal will be core20). For this to happen, we need bionic to have the
  same EXTRA_SNAPS support as we have in eoan as the new custom-image
  building solution relies on this feature.

  We actually might need to do the same for xenial to enable the same
  feature for core16.

  [Test Case]

  Run a livefs build of core18 using the bionic-proposed (or xenial-
  proposed) series and add an EXTRA_SNAPS list of snaps in the metadata
  override (e.g. "hello-world"). Check the logs to see if the extra
  snaps have been pulled into the image.

  [Regression Potential]

  Basically none. The only regression potential I can think of is by
  this change being wrongly backported and somehow causing ubuntu-core
  builds to fail or incorrectly pass additional arguments - but we don't
  actually rely on that.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1849491/+subscriptions