[Bug 1600308] Re: ubiquity targets invalid device name with nvme disks, fails to install grub

[Mathieu Trudel-Lapierre]

** Changed in: ubiquity (Ubuntu Xenial)
     Assignee: Mathieu Trudel-Lapierre (cyphermox) => (unassigned)

** Changed in: ubiquity (Ubuntu Xenial)
       Status: In Progress => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubiquity in Ubuntu.
https://bugs.launchpad.net/bugs/1600308

Title:
  ubiquity targets invalid device name with nvme disks, fails to install
  grub

Status in ubiquity package in Ubuntu:
  Fix Released
Status in ubiquity source package in Trusty:
  Fix Released
Status in ubiquity source package in Xenial:
  Triaged

Bug description:
  [Impact]
  Users with NVMe disks.

  [Test case]
  - Install system with NVMe disks; expect to pick the boot device.
  Install should complete succesfully.

  [Regression Potential]
  This only adds matching for NVMe devices; any such devices will now be matched based on the partition numbers rather than risking to match a character device for NVMe formatting. This does not match regular block devices and partitions.

  ---

  On Ubuntu 16.04, when installing Ubuntu to an nvme drive, Ubiquity
  fails to install grub.  In ubiquity/misc.py the function default_grub
  targets /dev/nvme0 instead of /dev/nvme0n1, which is the real name of
  the device.

  For single drive scenarios, this can be fixed by filtering out nvme devices from the regex line:
  old:
  target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/[a-z]+).*',
                              r'\1', target)
  fixed:
  target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/(?!nvme)[a-z]+).*',
                              r'\1', target)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1600308/+subscriptions