[Bug 1803958] Re: [UBUNTU] zkey: Fails to run commands generated by 'zkey cryptsetup'

[Robie Basak]

The fix for this bug seems to have been inadvertently dropped from the
current development release as far as I can tell. Something happened
between 2.6.0-0ubuntu7 and 2.7.1-0ubuntu1 - 2.6.0-0ubuntu8,
2.6.0-0ubuntu9 and 2.6.0-0ubuntu10 are missing from debian/changelog in
2.7.1-0ubuntu1, and the fix for this bug was in 2.6.0-0ubuntu10 but
vanished in 2.7.1-0ubuntu1. It looks like other fixes were also dropped
somewhere, but I haven't investigated further.

Please could you investigate, fix up as needed, and explain what
happened and how it was resolved so I can understand how to review this?

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to s390-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1803958

Title:
  [UBUNTU] zkey: Fails to run commands generated by 'zkey cryptsetup'

Status in Ubuntu on IBM z Systems:
  In Progress
Status in s390-tools package in Ubuntu:
  Fix Released
Status in s390-tools source package in Cosmic:
  New

Bug description:
  [Impact]

   * zkey utility attempts to execute cryptsetup binary and fails to
  find it, due to setting invalid PATH variable (which is missing
  /sbin). Stop resetting the PATH, and use the correct system default
  PATH which leads to correct execution of cryptsetup binary.

  
  [Test Case]

   * enroll system with crypto adapters / get ready to use zkey
   * generate appropriate zkey for an encryption device
   * Use `$ zkey cryptsetup --run` to perform cryptsetup commands via zkey

  [Regression Potential]

   * Currently only '--run' argument is broken, without '--run' the
  commands are printed that one can simply copy&paste and execute
  correctly under sudo. The effects of broken path, and using system
  path, have been discussed in depth at
  https://github.com/ibm-s390-tools/s390-tools/commit/9100327092c470c2e5b5819087c8094822a1c751
  and will result in correctly attempting to execute cryptsetup binary.
  (it may later fail for other reasons, but that's beyond the scope
  here).

  [Other Info]
   
   * Original bug report.

  Description:  zkey: Fails to run commands generated by 'zkey
  cryptsetup'

  Symptom:      Fails to run commands generated by 'zkey cryptsetup'.

  Problem:  When using 'zkey cryptsetup' with --run option the execution
  of the generated commands may fail, when  the executable to be run is
  located in '/sbin'.

  Solution:     Include /sbin into PATH when executing commands.

  Reproduction: Use 'zkey cryptsetup' with option --run on a distribution
                where 'cryptsetup' is located in '/sbin'.

  Upstream commit:
  https://github.com/ibm-s390-tools/s390-tools/commit/9100327092c470c2e5b5819087c8094822a1c751

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1803958/+subscriptions