[Bug 1813063] Re: ndiswrapper 1.60-6 ADT test failure with linux 5.0.0-1.2

[Connor Kuehl]

** Description changed:

+ NOTE: This SRU template was added 2019-05-10 after the original report
+ was opened and was fixed for Disco. I'm adding this because this problem
+ is affecting the Bionic HWE Edge kernel this SRU cycle. -connork
+ 
+ [Impact]
+ 
+  * The DKMS package fails to install on kernels based on 5.0;
+ specifically noticed in the Bionic HWE Edge kernel.
+ 
+ [The Problem]
+ This module uses the "do_gettimeofday" API which has been deprecated and removed from the 5.0 kernels. As a result, on a 5.0 kernel, the module will not compile successfully during installation since it depends on symbols that are no longer there.
+ 
+ [Proposed Fix]
+ Backport the following patch which has already landed in Disco's version of this package to support the 5.0 kernels: https://salsa.debian.org/jak/ndiswrapper/commit/f4502d63e8731b20b436a1266e96c5416e02a3af
+ 
+ [Test Case]
+  * Install the ndiswrapper-dkms package with a 5.0 kernel. The package should install without any errors.
+ 
+ [Testing]
+ 
+ - Create an Ubuntu 18.04 VM
+ - Install the HWE Edge kernel from -proposed (or one can find .debs here: https://launchpad.net/~canonical-kernel-team/+archive/ubuntu/ppa/+packages?field.name_filter=linux-hwe-edge&field.status_filter=published&field.series_filter=bionic)
+ - Install ndiswrapper; you can use apt ("sudo apt update" "sudo apt install ndiswrapper-dkms") or you can use "pull-lp-source ndiswrapper bionic" to build and install the .deb from that
+ - Confirm that installation fails
+ - Remove it "sudo apt remove ndiswrapper-dkms"
+ - If you haven't already: "pull-lp-source ndiswrapper bionic"
+ - Apply the debdiff ("debdiff-apply < ../ndiswrapper_1.60-6ubuntu0.1.debdiff")
+ - Build the package ("debuild -us -uc")
+ - Install the package
+ - Verify it installs successfully! ("sudo dkms status")
+ 
+ [Regression Potential]
+ 
+  * Low. Changes are conditionally compiled based on the kernel being >=
+ 5.0. These changes have also been in Disco.
+ 
+ 
  Testing failed on:
-     amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/amd64/n/ndiswrapper/20190123_164111_540fe@/log.gz
-     i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/i386/n/ndiswrapper/20190123_172043_540fe@/log.gz
+     amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/amd64/n/ndiswrapper/20190123_164111_540fe@/log.gz
+     i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/i386/n/ndiswrapper/20190123_172043_540fe@/log.gz

** Description changed:

  NOTE: This SRU template was added 2019-05-10 after the original report
  was opened and was fixed for Disco. I'm adding this because this problem
  is affecting the Bionic HWE Edge kernel this SRU cycle. -connork
  
  [Impact]
  
-  * The DKMS package fails to install on kernels based on 5.0;
+  * The DKMS package fails to install on kernels based on 5.0;
  specifically noticed in the Bionic HWE Edge kernel.
  
  [The Problem]
  This module uses the "do_gettimeofday" API which has been deprecated and removed from the 5.0 kernels. As a result, on a 5.0 kernel, the module will not compile successfully during installation since it depends on symbols that are no longer there.
  
  [Proposed Fix]
  Backport the following patch which has already landed in Disco's version of this package to support the 5.0 kernels: https://salsa.debian.org/jak/ndiswrapper/commit/f4502d63e8731b20b436a1266e96c5416e02a3af
  
  [Test Case]
-  * Install the ndiswrapper-dkms package with a 5.0 kernel. The package should install without any errors.
+  * Install the ndiswrapper-dkms package with a 5.0 kernel. The package should install without any errors.
  
  [Testing]
+ 
+ These instructions were followed using the .debdiff in comment #5
  
  - Create an Ubuntu 18.04 VM
  - Install the HWE Edge kernel from -proposed (or one can find .debs here: https://launchpad.net/~canonical-kernel-team/+archive/ubuntu/ppa/+packages?field.name_filter=linux-hwe-edge&field.status_filter=published&field.series_filter=bionic)
  - Install ndiswrapper; you can use apt ("sudo apt update" "sudo apt install ndiswrapper-dkms") or you can use "pull-lp-source ndiswrapper bionic" to build and install the .deb from that
  - Confirm that installation fails
  - Remove it "sudo apt remove ndiswrapper-dkms"
  - If you haven't already: "pull-lp-source ndiswrapper bionic"
  - Apply the debdiff ("debdiff-apply < ../ndiswrapper_1.60-6ubuntu0.1.debdiff")
  - Build the package ("debuild -us -uc")
  - Install the package
  - Verify it installs successfully! ("sudo dkms status")
  
  [Regression Potential]
  
-  * Low. Changes are conditionally compiled based on the kernel being >=
+  * Low. Changes are conditionally compiled based on the kernel being >=
  5.0. These changes have also been in Disco.
- 
  
  Testing failed on:
      amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/amd64/n/ndiswrapper/20190123_164111_540fe@/log.gz
      i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/i386/n/ndiswrapper/20190123_172043_540fe@/log.gz

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ndiswrapper in Ubuntu.
https://bugs.launchpad.net/bugs/1813063

Title:
  ndiswrapper 1.60-6 ADT test failure with linux 5.0.0-1.2

Status in ndiswrapper package in Ubuntu:
  Fix Released

Bug description:
  NOTE: This SRU template was added 2019-05-10 after the original report
  was opened and was fixed for Disco. I'm adding this because this
  problem is affecting the Bionic HWE Edge kernel this SRU cycle.
  -connork

  [Impact]

   * The DKMS package fails to install on kernels based on 5.0;
  specifically noticed in the Bionic HWE Edge kernel.

  [The Problem]
  This module uses the "do_gettimeofday" API which has been deprecated and removed from the 5.0 kernels. As a result, on a 5.0 kernel, the module will not compile successfully during installation since it depends on symbols that are no longer there.

  [Proposed Fix]
  Backport the following patch which has already landed in Disco's version of this package to support the 5.0 kernels: https://salsa.debian.org/jak/ndiswrapper/commit/f4502d63e8731b20b436a1266e96c5416e02a3af

  [Test Case]
   * Install the ndiswrapper-dkms package with a 5.0 kernel. The package should install without any errors.

  [Testing]

  These instructions were followed using the .debdiff in comment #5

  - Create an Ubuntu 18.04 VM
  - Install the HWE Edge kernel from -proposed (or one can find .debs here: https://launchpad.net/~canonical-kernel-team/+archive/ubuntu/ppa/+packages?field.name_filter=linux-hwe-edge&field.status_filter=published&field.series_filter=bionic)
  - Install ndiswrapper; you can use apt ("sudo apt update" "sudo apt install ndiswrapper-dkms") or you can use "pull-lp-source ndiswrapper bionic" to build and install the .deb from that
  - Confirm that installation fails
  - Remove it "sudo apt remove ndiswrapper-dkms"
  - If you haven't already: "pull-lp-source ndiswrapper bionic"
  - Apply the debdiff ("debdiff-apply < ../ndiswrapper_1.60-6ubuntu0.1.debdiff")
  - Build the package ("debuild -us -uc")
  - Install the package
  - Verify it installs successfully! ("sudo dkms status")

  [Regression Potential]

   * Low. Changes are conditionally compiled based on the kernel being
  >= 5.0. These changes have also been in Disco.

  Testing failed on:
      amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/amd64/n/ndiswrapper/20190123_164111_540fe@/log.gz
      i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/i386/n/ndiswrapper/20190123_172043_540fe@/log.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ndiswrapper/+bug/1813063/+subscriptions