[Bug 1827951] Re: snaps not refreshed when upgrading from bionic or cosmic to disco

[Brian Murray]

I tested an upgrade from bionic to disco and confirmed that this is
fixed.

root at clean-bionic-amd64:/tmp/ubuntu-release-upgrader-bctl6u37# head -n10 /var/log/dist-upgrade/main.log 
2019-05-09 16:02:07,695 INFO Using config files '['./DistUpgrade.cfg.bionic']'
2019-05-09 16:02:07,695 INFO uname information: 'Linux clean-bionic-amd64 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64'
2019-05-09 16:02:08,038 INFO apt version: '1.6.10'
2019-05-09 16:02:08,038 INFO python version: '3.6.7 (default, Oct 22 2018, 11:32:17) 
[GCC 8.2.0]'
2019-05-09 16:02:08,040 INFO release-upgrader version '19.04.16.4' started
2019-05-09 16:02:08,047 INFO locale: 'en_US' 'UTF-8'
2019-05-09 16:02:08,116 DEBUG setting up environ for non-interactive use
2019-05-09 16:02:08,158 DEBUG Using 'DistUpgradeViewNonInteractive' view
2019-05-09 16:02:08,194 DEBUG enable dpkg --force-overwrite

root at clean-bionic-amd64:/tmp/ubuntu-release-upgrader-bctl6u37# grep -A1 "Snap gnome-calculator" /var/log/dist-upgrade/main.log
2019-05-09 16:18:21,301 DEBUG Snap gnome-calculator is installed
2019-05-09 16:18:23,282 DEBUG refresh of snap gnome-calculator succeeded
root at clean-bionic-amd64:/tmp/ubuntu-release-upgrader-bctl6u37# snap info gnome-calculator
name:      gnome-calculator
summary:   GNOME Calculator
publisher: Canonical✓
license:   unset
description: |
  GNOME Calculator is an application that solves mathematical equations.
  Though it at first appears to be a simple calculator with only basic
  arithmetic operations, you can switch into Advanced, Financial, or
  Programming mode to find a surprising set of capabilities.

  The Advanced calculator supports many operations, including:
  logarithms, factorials, trigonometric and hyperbolic functions,
  modulus division, complex numbers, random number generation, prime
  factorization and unit conversions.

  Financial mode supports several computations, including periodic interest
  rate, present and future value, double declining and straight line
  depreciation, and many others.

  Programming mode supports conversion between common bases (binary, octal,
  decimal, and hexadecimal), boolean algebra, one’s and two’s complementation,
  character to character code conversion, and more.
commands:
  - gnome-calculator
snap-id:      J8OcDPQ0JM8dbvk29HRqpWVI9kBw0atG
tracking:     stable/ubuntu-19.04
refresh-date: 29 days ago, at 17:20 PDT
channels:
  stable:    3.32.1                2019-04-10 (406) 4MB -
  candidate: 3.32.1                2019-04-09 (406) 4MB -
  beta:      ↑
  edge:      3.32.0+git23.3b31d463 2019-04-20 (408) 4MB -
installed:   3.32.1                           (406) 4MB -

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1827951

Title:
  snaps not refreshed when upgrading from bionic or cosmic to disco

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Disco:
  Fix Committed

Bug description:
  [Impact]
  People have outdated snaps!
  The function _replaceDebsWithSnaps() has the version number of Ubuntu hardcoded in it and was not updated in Ubuntu 19.04. Subsequently, the snaps are not refreshed when upgrading from Ubuntu 18.10 to Ubuntu 19.04. This was fixed in Eoan by utilizing python distro_info's ability to get the release version for a codename but unfortunately that's not available in Ubuntu 19.04 so we'll just update the hardcoded version.

  [Test Case]
  1) on a cosmic or bionic system run do-release-upgrade and upgrade to disco
  2) observe the following in /var/log/dist-upgrade/main.log
  2019-05-07 11:38:20,921 DEBUG Snap gnome-calculator is installed
  2019-05-07 11:38:20,921 DEBUG Snap gnome-calculator is not tracking the release channel
  3) also check the output of "snap info gnome-calculator" for tracking "stable/18.10" (or 18.04)

  With the version of the release-upgrader in -proposed (do-release-upgrade -p) gnome-calculator will end up tracking 19.04 and you'll see the following in main.log:
  "2019-05-07 12:41:25,611 DEBUG refresh of snap gnome-calculator succeeded"

  [Regression Potential]
  I've set fromVersion to a default value of '' so I think there is little chance of there being a regression.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1827951/+subscriptions