[Bug 1828072] Re: KernelRemoval section is out of date

[Brian Murray]

I tested this with an upgrade from cosmic to disco and it too passed.

root at clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-6d11obk0# head -n10 /var/log/dist-upgrade/main.log 
2019-05-09 15:22:33,860 INFO Using config files '['./DistUpgrade.cfg']'
2019-05-09 15:22:33,860 INFO uname information: 'Linux clean-cosmic-amd64 4.18.0-18-generic #19-Ubuntu SMP Tue Apr 2 18:13:16 UTC 2019 x86_64'
2019-05-09 15:22:34,195 INFO apt version: '1.7.4'
2019-05-09 15:22:34,195 INFO python version: '3.6.8 (default, Apr  9 2019, 04:59:38) 
[GCC 8.3.0]'
2019-05-09 15:22:34,198 INFO release-upgrader version '19.04.16.4' started
2019-05-09 15:22:34,207 INFO locale: 'en_US' 'UTF-8'
2019-05-09 15:22:34,273 DEBUG setting up environ for non-interactive use
2019-05-09 15:22:34,314 DEBUG Using 'DistUpgradeViewNonInteractive' view
2019-05-09 15:22:34,346 DEBUG enable dpkg --force-overwrite
root at clean-cosmic-amd64:/tmp/ubuntu-release-upgrader-6d11obk0# grep -i obsoletekernel /var/log/dist-upgrade/main.log
2019-05-09 15:37:48,149 DEBUG identifyObsoleteKernels()
2019-05-09 15:37:52,532 DEBUG identifyObsoleteKernels found '{'linux-modules-extra-4.18.0-10-generic', 'linux-modules-4.18.0-10-generic', 'linux-image-unsigned-4.18.0-10-generic', 'linux-headers-4.18.0-10-generic'}'

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1828072

Title:
  KernelRemoval section is out of date

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Bionic:
  Fix Committed
Status in ubuntu-release-upgrader source package in Cosmic:
  Fix Committed
Status in ubuntu-release-upgrader source package in Disco:
  Fix Committed

Bug description:
  The dist-upgrader tarball includes configuration files for the release
  upgrade process and part of the configuration file is a section with
  the heading KernelRemoval which includes Version, BaseNames, and Types
  which are used to build a list of kernels to remove. This section has
  not been updated in quite some time and we should up date so systems
  have less old kernels installed.

  [Test Case]
  1) upgrade a system from a release of Ubuntu to a new release of Ubuntu (this should be done for the following paths B->C, C->D, B->D)
  2) observe the following in /var/log/dist-upgrade/main.log
  "2019-05-07 11:38:23,264 DEBUG identifyObsoleteKernels()
  2019-05-07 11:38:27,621 DEBUG identifyObsoleteKernels found 'set()'"

  The release upgrader from -proposed (do-release-upgrader -p) should
  identify some obsolete kernels ("skipping running kernel linux-
  headers-5.0.0-13-generic") even if it doesn't end up removing them.

  [Regression Potential]
  I made the BaseNames section split out across multiple lines which should be fine but that could cause the config file to fail to be parsed which would probably cause a crash or the same failure to remove obsolete kernels.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1828072/+subscriptions