[Bug 1800670] Re: Improve error reporting to give clearer messages and context
Launchpad Bug Tracker
1800670 at bugs.launchpad.net
Wed May 8 00:00:42 UTC 2019
This bug was fixed in the package netplan.io - 0.96-0ubuntu0.18.04.4
---------------
netplan.io (0.96-0ubuntu0.18.04.4) bionic; urgency=medium
* debian/patches/git_revert_explicit_renderer_def_ebc212a.patch: revert
commit ebc212a: make renderer values explicit at the end of each parsing
pass; it breaks "default" renderer behavior when multiple files may set
a global renderer and expect the last to take effect globally.
(LP: #1825206)
* debian/patches/git_reorg_netdef_validation_181b583.patch: correct the
fallout from the above change: validate netdefs in a single pass at the
very end of parsing, once we know which is the applicable renderer. This
makes sure tunnels get validated correctly.
netplan.io (0.96-0ubuntu0.18.04.3) bionic; urgency=medium
* debian/patches/disable-networkd-tunnels-ipip-gre.patch: disable IPIP and
GRE tunnel tests; those appear to be broken because neither the kernel nor
networkd bring up the device automatically as in other releases.
netplan.io (0.96-0ubuntu0.18.04.2) bionic; urgency=medium
* d/p/0001-Partially-revert-the-change-for-enabling-systemd-net.patch:
Partially revert changes to networkd jobs ordering: leave systemd-networkd
enabled in multi-user.target instead of network-online.target, as in some
minimal setups there might be no job requiring network-online.target,
whereas the natural target to reach for booting is multi-user.target.
(LP: #1821867)
netplan.io (0.96-0ubuntu0.18.04.1) bionic; urgency=medium
* Backport netplan.io 0.96 to 18.04.
* debian/patches/glib_changes.patch: Patch tests to work again on older GLib.
* debian/control: adjust Depends for bionic / re-add nplan package.
netplan.io (0.96-0ubuntu1) disco; urgency=medium
* New upstream release 0.96.
- Moved netplan-wpa@ services to earlier at boot (LP: #1819014)
- Restart services when unconfiguring (LP: #1811868)
- Use the .nmconnection extension for NM keyfiles (LP: #1817655)
- Fixed integration tests runner to correctly report failures
- Enforce integrity for use-routes in networkd backend.
- Ensure terminal state at end of test (LP: #1817660)
- Various small test fixes.
- Fix typos in documentation.
* debian/control: Update Maintainer for ubuntu upload.
netplan.io (0.95-2) unstable; urgency=medium
* Set Priority to optional (Closes: #920327).
netplan.io (0.95-1) unstable; urgency=medium
* New upstream release.
* Update autopkgtests from the upstream.
* Add debian/watch following GitHub releases.
* Add Homepage (Closes: #917233).
netplan.io (0.95) disco; urgency=medium
* New upstream release:
- Added support for WPA Enterprise / 802.1x authentication (LP: #1739578)
- Added support for setting up IP tunnels; supporting the types: ipip,
gretap, VTI, ISATAP (NetworkManager only), sit, gre, ipip6 and ip6ip6.
+ Fixes sit (ipv6) tunnels using Hurricane Electric (LP: #1799487)
- Add support to override networkd UseMTU setting (LP: #1807273)
- Generate output files in dependency order
- Refactored unit and integration tests, along with various cleanups.
- Add DHCP overrides to control route usage and default metric for DHCP
routes. (LP: #1776228)
- Mitigate against bad matching on devices behind bonds then they share
the same MAC from a physical interface. (LP: #1804861)
- Added snapcraft.yaml.
netplan.io (0.90.1) disco; urgency=medium
* Do not assume /etc/network exists in postinst, as netbase 5.5 no longer
creates it.
* netplan/cli/commands/ip.py: fix a flake.
netplan.io (0.90) disco; urgency=medium
* New upstream release:
- build: fixes for building on RPM-based distros
- build: code prettiness changes (make indentation consistent)
- Fix device name-changes detection (LP: #1770082)
- Add support for IPv6 Privacy Extensions (LP: #1750392)
- Add dhcp{4,6}-overrides to control DNS, NTP, hostname updates via DHCP
(LP: #1759014)
- Clarify MAC and MTU setting requirements (LP: #1800668)
- Various documentation fixes (LP: #1800669)
- Improve error reporting to give clearer messages and context
(LP: #1800670)
- Skip non-physical/bond interfaces when applying renames (LP: #1802322)
netplan.io (0.40.2-1) unstable; urgency=medium
* Upload to Debian (Closes: #882661).
netplan.io (0.40.2) cosmic; urgency=medium
* tests/integration.py: Mark regexes with r to pacify pycodestyle's
W605.
-- Mathieu Trudel-Lapierre <cyphermox at ubuntu.com> Fri, 26 Apr 2019
15:19:47 -0400
** Changed in: netplan.io (Ubuntu Bionic)
Status: Fix Committed => Fix Released
** Changed in: netplan.io (Ubuntu Cosmic)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to netplan.io in Ubuntu.
Matching subscriptions: foundations-bugs
https://bugs.launchpad.net/bugs/1800670
Title:
Improve error reporting to give clearer messages and context
Status in netplan:
Fix Released
Status in netplan.io package in Ubuntu:
Fix Released
Status in netplan.io source package in Bionic:
Fix Released
Status in netplan.io source package in Cosmic:
Fix Released
Status in netplan.io source package in Disco:
Fix Released
Bug description:
[Impact]
All users of netplan.
[Test case]
1) Write an invalid netplan yaml (for each of the examples below)
2) Validate the error is as expected.
3) Verify that the error matches refers to a meaningful place in file (check line and column values).
== Error due to missing fields ==
network:
version: 2
ethernets:
engreen:
routing-policy:
- table: 50
addresses:
- 192.168.14.2/24
- 2001:FFfe::1/64
Expected error:
"""
/etc/netplan/01-network-manager-all.yaml:10:9: Error in network definition: IP routing policy must include either a 'from' or 'to' IP
- table: 50
^
"""
== Syntax error: unsupported features ==
network:
version: 2
ethernets:
engreen:
dhcp4: *yes
Expected error:
"""
/etc/netplan/01-network-manager-all.yaml:9:14: Invalid YAML: aliases are not supported:
dhcp4: *yes
^
"""
== Syntax error: use of tabs in config ==
network:
<tab>version: 2
<tab>renderer: NetworkManager
Expected error:
"""
/etc/netplan/01-network-manager-all.yaml:3:1: Invalid YAML: tabs are not allowed for indent:
version: 2
^
"""
== Unsupported mix of features ==
network:
version: 2
renderer: networkd
tunnels:
tun0:
mode: isatap
local: 1.1.1.1
remote: 2.2.2.2
addresses: [ 15.15.15.15/24 ]
gateway4: 20.20.20.21
Expected error:
"""
/etc/netplan/01-network-manager-all.yaml:10:7: Error in network definition: tun0: ISATAP tunnel mode is not supported by networkd
mode: isatap
^
"""
[Regression potential]
Minimal. Supported configurations remain unchanged. Users relying on automated parsing of netplan error messages (would that be a thing?) will find the messages have vastly changed. None of the strings are currently translatable/translated.
---
Give more information about the error, including its exact location in
the code.
Make the error messages shorter but still understandable.
Present clear context so people understand what we found was wrong, if
not from line/column number, then from the extract from their file,
with a marker to the error.
To manage notifications about this bug go to:
https://bugs.launchpad.net/netplan/+bug/1800670/+subscriptions
More information about the foundations-bugs
mailing list