[Bug 1813587] Re: libunistring and libidn ftbfs on 18.04 LTS

[Gianfranco Costamagna]

libunistring backport patch to cosmic from Disco:
diff -Nru libunistring-0.9.10/debian/changelog libunistring-0.9.10/debian/changelog
--- libunistring-0.9.10/debian/changelog        2018-07-23 16:46:28.000000000 +0200
+++ libunistring-0.9.10/debian/changelog        2019-03-27 12:21:30.000000000 +0100
@@ -1,3 +1,10 @@
+libunistring (0.9.10-1ubuntu1.18.10.1) cosmic; urgency=medium
+
+  * Cherry-pick pthread fix from upstream and disco release.
+    (LP: #1813587)
+
+ -- Gianfranco Costamagna <locutusofborg at debian.org>  Wed, 27 Mar 2019 12:21:30 +0100
+
 libunistring (0.9.10-1ubuntu1) cosmic; urgency=medium

   * Do not set as-needed, to work-around a testsuite failure
diff -Nru libunistring-0.9.10/debian/patches/cca32830b57e91f837c01d15b8732f23ff97fc36.patch libunistring-0.9.10/debian/patches/cca32830b57e91f837c01d15b8732f23ff97fc36.patch
--- libunistring-0.9.10/debian/patches/cca32830b57e91f837c01d15b8732f23ff97fc36.patch   1970-01-01 01:00:00.000000000 +0100
+++ libunistring-0.9.10/debian/patches/cca32830b57e91f837c01d15b8732f23ff97fc36.patch   2019-03-27 12:21:14.000000000 +0100
@@ -0,0 +1,15 @@
+Description: Fix link failure with upstream gnulib patch
+Origin: https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=cca32830b57e91f837c01d15b8732f23ff97fc36
+Last-Update: 2019-03-20
+
+--- libunistring-0.9.10.orig/tests/glthread/thread.h
++++ libunistring-0.9.10/tests/glthread/thread.h
+@@ -133,8 +133,6 @@ extern int glthread_in_use (void);
+    call to foo(...) in the same function.  To avoid this, we test the
+    address of a function in libpthread that we don't use.  */
+ 
+-#  pragma weak pthread_create
+-
+ #  ifndef pthread_sigmask /* Do not declare rpl_pthread_sigmask weak.  */
+ #   pragma weak pthread_sigmask
+ #  endif
diff -Nru libunistring-0.9.10/debian/patches/series libunistring-0.9.10/debian/patches/series
--- libunistring-0.9.10/debian/patches/series   2018-07-23 16:46:28.000000000 +0200
+++ libunistring-0.9.10/debian/patches/series   2019-03-27 12:21:14.000000000 +0100
@@ -1,2 +1,3 @@
 0100-float-endian-detection.patch
 0700-multiarch-libc.patch
+cca32830b57e91f837c01d15b8732f23ff97fc36.patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to libidn in Ubuntu.
https://bugs.launchpad.net/bugs/1813587

Title:
  libunistring and libidn ftbfs on 18.04 LTS

Status in libidn package in Ubuntu:
  Fix Released
Status in libunistring package in Ubuntu:
  Fix Released
Status in libidn source package in Bionic:
  In Progress
Status in libunistring source package in Bionic:
  Fix Committed
Status in libidn source package in Cosmic:
  In Progress
Status in libunistring source package in Cosmic:
  In Progress
Status in libunistring package in Debian:
  New

Bug description:
  Impact
  ------
  libunistring doesn't build from source which means someone would need to fix that problem before fixing any bugs in the libunistring package for Ubuntu 18.04 LTS.

  Test Case
  ---------
  Does libunistring build successfully?

  Regression Potential
  --------------------
  We are simply backporting the workaround we applied in Ubuntu 19.04.

  Original Bug Report
  -------------------
  according to
  http://people.canonical.com/~doko/ftbfs-report/test-rebuild-20181222-bionic.html

  libunistring ftbfs.

  FAIL: test-thread_create
  ========================

  glthread_create failed
  FAIL test-thread_create (exit status: 1)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libidn/+bug/1813587/+subscriptions