[Bug 1814952] Re: netplan try crashes if exception occurs

[Mathieu Trudel-Lapierre]

*** This bug is a duplicate of bug 1817660 ***
    https://bugs.launchpad.net/bugs/1817660

** Changed in: netplan
       Status: New => Fix Released

** Also affects: netplan.io (Ubuntu)
   Importance: Undecided
       Status: New

** This bug has been marked a duplicate of bug 1817660
   test_terminal.TestTerminal tests fail when run a second time

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to netplan.io in Ubuntu.
Matching subscriptions: foundations-bugs
https://bugs.launchpad.net/bugs/1814952

Title:
  netplan try crashes if exception occurs

Status in netplan:
  Fix Released
Status in netplan.io package in Ubuntu:
  New

Bug description:
  [Impact]
  If netplan try fails to get a file descriptor for stdin, an exception is thrown and caught, but it then crashes rather than cleaning up and gracefully exiting because it tries to access a variable that was only instantiated within the try and doesn't exist at the time of the "finally" clause.

  [Replication]

  Easiest way to replicate is via ssh without forcing a tty:

  $ ssh root at dns12.xxxxxxx 'netplan try'

  Warning: Stopping systemd-networkd.service, but it can still be activated by:
    systemd-networkd.socket

  An error occurred: (25, 'Inappropriate ioctl for device')

  Reverting.
  Traceback (most recent call last):
    File "/usr/sbin/netplan", line 23, in <module>
      netplan.main()
    File "/usr/share/netplan/netplan/cli/core.py", line 50, in main
      self.run_command()
    File "/usr/share/netplan/netplan/cli/utils.py", line 130, in run_command
      self.func()
    File "/usr/share/netplan/netplan/cli/commands/try_command.py", line 65, in run
      self.run_command()
    File "/usr/share/netplan/netplan/cli/utils.py", line 130, in run_command
      self.func()
    File "/usr/share/netplan/netplan/cli/commands/try_command.py", line 95, in command_try
      self.t.reset(self.t_settings)
  AttributeError: 'NetplanTry' object has no attribute 't'


  PR opened: https://github.com/CanonicalLtd/netplan/pull/71

To manage notifications about this bug go to:
https://bugs.launchpad.net/netplan/+bug/1814952/+subscriptions