[Bug 1680599] Re: unattended-upgrades crashes without writing to the log on invalid config file entries

[Balint Reczey]

Tested with 1.1ubuntu1.18.04.7~16.04.2 on Xenial:

root at x-uu-lp-1260041:~# unattended-upgrade --dry-run --debug
Unable to parse Unattended-Upgrade::Allowed-Origins.
Traceback (most recent call last):
  File "/usr/bin/unattended-upgrade", line 1998, in <module>
    sys.exit(main(options))
  File "/usr/bin/unattended-upgrade", line 1565, in main
    allowed_origins = get_allowed_origins()
  File "/usr/bin/unattended-upgrade", line 475, in get_allowed_origins
    allowed_origins = get_allowed_origins_legacy()
  File "/usr/bin/unattended-upgrade", line 454, in get_allowed_origins_legacy
    (distro_id, distro_codename) = s.split()
ValueError: not enough values to unpack (expected 2, got 1)
root at x-uu-lp-1260041:~# cat /var/log/unattended-upgrades/unattended-upgrades.log 
2019-03-13 17:23:53,035 ERROR Unable to parse Unattended-Upgrade::Allowed-Origins.
root at x-uu-lp-1260041:~# dpkg -l unattended-upgrades | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                Version                    Architecture Description
+++-===================-==========================-============-===========================================
ii  unattended-upgrades 1.1ubuntu1.18.04.7~16.04.2 all          automatic installation of security upgrades


** Tags removed: verification-needed verification-needed-xenial
** Tags added: verification-done verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unattended-upgrades in Ubuntu.
https://bugs.launchpad.net/bugs/1680599

Title:
  unattended-upgrades crashes without writing to the log on invalid
  config file entries

Status in unattended-upgrades package in Ubuntu:
  Fix Released
Status in unattended-upgrades source package in Xenial:
  Fix Committed

Bug description:
  If Unattended-Upgrade::Allowed-Origins in 50unattended-upgrades
  contains an invalid entry, such as "invalid", unattended-upgrades
  crashes without writing to /var/log/unattended-upgrades/unattended-
  upgrades.log.

  # unattended-upgrades --debug
  Traceback (most recent call last):
    File "/usr/bin/unattended-upgrades", line 1536, in <module>
      main(options)
    File "/usr/bin/unattended-upgrades", line 1202, in main
      allowed_origins = get_allowed_origins()
    File "/usr/bin/unattended-upgrades", line 343, in get_allowed_origins
      allowed_origins = get_allowed_origins_legacy()
    File "/usr/bin/unattended-upgrades", line 328, in get_allowed_origins_legacy
      (distro_id, distro_codename) = s.split()
  ValueError: not enough values to unpack (expected 2, got 1)

  0.92ubuntu1.2 on 16.10

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1680599/+subscriptions