[Bug 1775307] Re: Unattended-upgrades crashes in adjusting candidates in 1.2ubuntu1 version

[Balint Reczey]

Tested 1.1ubuntu1.18.04.7~16.04.2 on Xenial.

root at x-uu-upgrade:~# unattended-upgrade --dry-run --verbose --debug
Initial blacklisted packages: 
Initial whitelisted packages: 
Starting unattended upgrades script
Allowed origins are: o=Ubuntu,a=xenial, o=Ubuntu,a=xenial-security, o=UbuntuESM,a=xenial
Using (^linux-image-[0-9]+\.[0-9\.]+-.*|^linux-headers-[0-9]+\.[0-9\.]+-.*|^linux-image-extra-[0-9]+\.[0-9\.]+-.*|^linux-modules-[0-9]+\.[0-9\.]+-.*|^linux-modules-extra-[0-9]+\.[0-9\.]+-.*|^linux-signed-image-[0-9]+\.[0-9\.]+-.*|^kfreebsd-image-[0-9]+\.[0-9\.]+-.*|^kfreebsd-headers-[0-9]+\.[0-9\.]+-.*|^gnumach-image-[0-9]+\.[0-9\.]+-.*|^.*-modules-[0-9]+\.[0-9\.]+-.*|^.*-kernel-[0-9]+\.[0-9\.]+-.*|^linux-backports-modules-.*-[0-9]+\.[0-9\.]+-.*|^linux-modules-.*-[0-9]+\.[0-9\.]+-.*|^linux-tools-[0-9]+\.[0-9\.]+-.*|^linux-cloud-tools-[0-9]+\.[0-9\.]+-.*) regexp to find kernel packages
Using (^linux-image-4\.18\.0\-16\-generic$|^linux-headers-4\.18\.0\-16\-generic$|^linux-image-extra-4\.18\.0\-16\-generic$|^linux-modules-4\.18\.0\-16\-generic$|^linux-modules-extra-4\.18\.0\-16\-generic$|^linux-signed-image-4\.18\.0\-16\-generic$|^kfreebsd-image-4\.18\.0\-16\-generic$|^kfreebsd-headers-4\.18\.0\-16\-generic$|^gnumach-image-4\.18\.0\-16\-generic$|^.*-modules-4\.18\.0\-16\-generic$|^.*-kernel-4\.18\.0\-16\-generic$|^linux-backports-modules-.*-4\.18\.0\-16\-generic$|^linux-modules-.*-4\.18\.0\-16\-generic$|^linux-tools-4\.18\.0\-16\-generic$|^linux-cloud-tools-4\.18\.0\-16\-generic$) regexp to find running kernel packages
Checking: locales ([<Origin component:'main' archive:'xenial-updates' origin:'Ubuntu' label:'Ubuntu' site:'archive.ubuntu.com' isTrusted:True>])
adjusting candidate version: locales=2.23-0ubuntu10
pkgs that look like they should be upgraded: 
Fetched 0 B in 0s (0 B/s)                                                                                                                                                    
fetch.run() result: 0
blacklist: []
whitelist: []
No packages found that can be upgraded unattended and no pending auto-removals
root at x-uu-upgrade:~# dpkg -l unattended-upgrades | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                Version                    Architecture Description
+++-===================-==========================-============-===========================================
ii  unattended-upgrades 1.1ubuntu1.18.04.7~16.04.2 all          automatic installation of security upgrades


** Tags removed: verification-needed verification-needed-xenial
** Tags added: verification-done verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unattended-upgrades in Ubuntu.
https://bugs.launchpad.net/bugs/1775307

Title:
  Unattended-upgrades crashes in adjusting candidates in 1.2ubuntu1
  version

Status in unattended-upgrades package in Ubuntu:
  Fix Released
Status in unattended-upgrades source package in Xenial:
  Fix Committed
Status in unattended-upgrades source package in Bionic:
  Fix Released

Bug description:
  [Impact]

   * Unattended-upgrades fails to install updates when adjusting
  candidates is needed.

  [Test Case]

  Note that only 1.2ubuntu1 is affected. Earlier releases either did not
  crash or did not adjust candidates due to LP: #1775292. To reproduce
  the crash Cosmic's u-u 1.2ubuntu1 needs to be installed.

   * Run sudo apt update && sudo unattended-upgrade --dry-run --verbose --debug
   * Observe no line with "adjusting candidate version: " or a crash with buggy u-u versions
  ...
  adjusting candidate version: zfs-initramfs=0.7.5-1ubuntu15
  adjusting candidate version: zfs-test=0.7.5-1ubuntu15
  adjusting candidate version: zfs-zed=0.7.5-1ubuntu15
  adjusting candidate version: zfsutils-linux=0.7.5-1ubuntu15
  Traceback (most recent call last):
    File "/usr/bin/unattended-upgrade", line 1928, in <module>
      sys.exit(main(options))
    File "/usr/bin/unattended-upgrade", line 1554, in main
      allowed_origins=allowed_origins)
    File "/usr/bin/unattended-upgrade", line 122, in __init__
      apt.Cache.__init__(self, rootdir=rootdir)
    File "/usr/lib/python3/dist-packages/apt/cache.py", line 130, in __init__
      self.open(progress)
    File "/usr/bin/unattended-upgrade", line 152, in open
      self.adjust_candidates()
    File "/usr/bin/unattended-upgrade", line 161, in adjust_candidates
      for pkgname, candidate in self._get_candidates_to_adjust():
  ValueError: too many values to unpack (expected 2) * Install fixed u-u version

   * Run sudo unattended-upgrade --dry-run --verbose --debug
   * Observe lines "adjusting candidate version: " and no crash

  [Regression Potential]

   * Unattended-upgrade may crash when adjusting candidates preventing
  upgrades to be installed

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1775307/+subscriptions