[Bug 1817660] Re: test_terminal.TestTerminal tests fail when run a second time

[Mathieu Trudel-Lapierre]

** Description changed:

+ [Impact]
+ Limited to automatic testing run for netplan.
+ 
+ [Test cases]
+ 1) Run 'make check' on netplan source twice.
+ 2) Verify the tests pass both times.
+ 
+ [Regression potential]
+ None.
+ 
+ ---
+ 
  Several tests related setting terminal flags in
  test_terminal.TestTerminal fail when run a second time on the same
  terminal. They succeed the first time, then fail until you open a new
  terminal or SSH session.
  
  The cause appears to be that multiple tests such as test_save and
  test_save_and_restore_with_dict do not restore the terminal back to it's
  original clean state (O_NONBLOCK is left enabled) because the calls to
  .save() mean that .reset() restores back to that saved state.

** Changed in: netplan
       Status: In Progress => Fix Released

** Also affects: netplan.io (Ubuntu)
   Importance: Undecided
       Status: New

** Changed in: netplan.io (Ubuntu)
   Importance: Undecided => Medium

** Changed in: netplan.io (Ubuntu)
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to netplan.io in Ubuntu.
Matching subscriptions: foundations-bugs
https://bugs.launchpad.net/bugs/1817660

Title:
  test_terminal.TestTerminal tests fail when run a second time

Status in netplan:
  Fix Released
Status in netplan.io package in Ubuntu:
  In Progress

Bug description:
  [Impact]
  Limited to automatic testing run for netplan.

  [Test cases]
  1) Run 'make check' on netplan source twice.
  2) Verify the tests pass both times.

  [Regression potential]
  None.

  ---

  Several tests related setting terminal flags in
  test_terminal.TestTerminal fail when run a second time on the same
  terminal. They succeed the first time, then fail until you open a new
  terminal or SSH session.

  The cause appears to be that multiple tests such as test_save and
  test_save_and_restore_with_dict do not restore the terminal back to
  it's original clean state (O_NONBLOCK is left enabled) because the
  calls to .save() mean that .reset() restores back to that saved state.

To manage notifications about this bug go to:
https://bugs.launchpad.net/netplan/+bug/1817660/+subscriptions