[Bug 62905] Re: smart server is noisy on disconnection

[Jelmer Vernooij]

** Also affects: brz
   Importance: Undecided
       Status: New

** Changed in: brz
       Status: New => Triaged

** Changed in: brz
   Importance: Undecided => Medium

** Tags removed: check-for-breezy

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to bzr in Ubuntu.
https://bugs.launchpad.net/bugs/62905

Title:
  smart server is noisy on disconnection

Status in Breezy:
  Triaged
Status in Bazaar:
  Confirmed
Status in bzr package in Ubuntu:
  Invalid

Bug description:


  I start a server, then branch from a bzr:// URL and when the branching
  is done
  the server raises an exception:

  <bzrlib.transport.smart.SmartStreamServer object at 0x02223C90>
  terminating on
  exception (10054, 'Connection reset by peer')
  Exception in thread smart-server-child:
  Traceback (most recent call last):
    File "C:\Python24\lib\threading.py", line 442, in __bootstrap
      self.run()
    File "C:\Python24\lib\threading.py", line 422, in run
      self.__target(*self.__args, **self.__kwargs)
    File "C:\Python24\Lib\site-packages\bzrlib\transport\smart.py", line
  306, in serve
      while self._serve_one_request() != False:
    File "C:\Python24\Lib\site-packages\bzrlib\transport\smart.py", line
  284, in
  _serve_one_request
      req_args = self._recv_tuple()
    File "C:\Python24\Lib\site-packages\bzrlib\transport\smart.py", line
  268, in
  _recv_tuple
      return _recv_tuple(self._in)
    File "C:\Python24\Lib\site-packages\bzrlib\transport\smart.py", line
  172, in
  _recv_tuple
      req_line = from_file.readline()
    File "C:\Python24\lib\socket.py", line 340, in readline
      data = self._sock.recv(self._rbufsize)
  error: (10054, 'Connection reset by peer')

  It causes no problems and branching/pushing works fine next time again,
  but
  shouldn't be the disconnecting handled somehow? Or is this a
  Windows-specific bug?

   affects /bzr
  -- 
  GPG key available at: <http://www.robertcollins.net/keys.txt>.

To manage notifications about this bug go to:
https://bugs.launchpad.net/brz/+bug/62905/+subscriptions