[Bug 1629715] Re: [SRU] usb-creator-kde shows the install popup after a few seconds of launching without any input

[Walter Lapchynski]

** Patch added: "usb-creator_0.3.5ubuntu18.10.2.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/usb-creator/+bug/1629715/+attachment/5277471/+files/usb-creator_0.3.5ubuntu18.10.2.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to usb-creator in Ubuntu.
https://bugs.launchpad.net/bugs/1629715

Title:
  [SRU] usb-creator-kde shows the install popup after a few seconds of
  launching without any input

Status in usb-creator package in Ubuntu:
  Fix Released
Status in usb-creator source package in Xenial:
  Triaged
Status in usb-creator source package in Bionic:
  Triaged
Status in usb-creator source package in Cosmic:
  Triaged
Status in usb-creator source package in Disco:
  Triaged
Status in usb-creator source package in Eoan:
  Fix Released

Bug description:
  [SRU]

  [Impact]

  Unlike usb-creator-gtk, which has a different codebase, usb-creator-
  kde has long been non-functional, getting stuck immediately upon
  launching. This means that for Kubuntu, post-18.04 Lubuntu, and any
  user who chooses to use usb-creator-kde, it is useless.

  There is code to setup a progress dialog for when a USB is being
  written to, but it is  in the class initialization, so it displays
  immediately. This moves that to the actual install method so it
  doesn't appear until the user clicks the button the perform the USB
  install.

  [Test Case]

  To reproduce the bug, simply launch usb-creator-kde (Startup Disk
  Creator in the menu).

  If the bug is present, the installation popup immediately displays,
  rendering the program unusable.

  If the bug is NOT present, the program should wait for the ISO and
  target to be specified and the button to perform the install to be
  clicked before the installation popup shows.

  It is highly recommended that a USB install is performed as part of
  the testing if the bug is not present. See below.

  [Regression Potential]

  The patch is small, applies cleanly, and does nothing to change logic.
  It merely moves logic around. There should be no reason why this
  should cause any sort of regression.

  The most likely cause of a regression would be the fact that the
  program has been unusable for so long, it hasn't seen a lot of use
  and, as such, its quality is a bit unknown. I would hope anyone
  testing would ensure that the basic function is there.

  ======================================

  [Original Description]

  STEPS TO REPRODUCE
   1. Launch usb-creator-kde (Startup Disk Creator)

  EXPECTED RESULTS
  Application launches normally, waiting for the ISO and target before installing.

  ACTUAL RESULTS
  Without any input, the installation popup immediately shows up, making the program unusable.

  AFFECTED VERSIONS
  0.3.2
  0.3.5
  (possibly earlier versions, but couldn't install in trusty)

  NOTES & WORKAROUND
  usb-creator-gtk is unaffected by this bug

  Tracked by Lubuntu here: https://phab.lubuntu.me/T51

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/usb-creator/+bug/1629715/+subscriptions