[Bug 1786484] Re: free space need for /usr could be negative which is wrong

[Łukasz Zemczak]

Hello Carlo, or anyone else affected,

Accepted ubuntu-release-upgrader into bionic-proposed. The package will
build now and be available at https://launchpad.net/ubuntu/+source
/ubuntu-release-upgrader/1:18.04.30 in a few hours, and then in the
-proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: ubuntu-release-upgrader (Ubuntu Bionic)
       Status: New => Fix Committed

** Tags removed: verification-done
** Tags added: verification-needed verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1786484

Title:
  free space need for /usr could be negative which is wrong

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Bionic:
  Fix Committed
Status in ubuntu-release-upgrader source package in Cosmic:
  Fix Released

Bug description:
  [Impact]
  The checkFreeSpace function doesn't ensure that the space needed is a positive number thereby causing a situation where a partition, like /usr, doesn't have enough free space which then results in a failure during upgrade.

  [Test Case]
  It's not clear to me how to recreate this scenario, however I believe this falls into the "obviously safe" patch category. The specific change to checkFreeSpace, which is described as "this checks if we have enough free space", from DistUpgradeCache.py follows:

  1200             # we are ensuring we have more than enough free space not less
  1201             if size < 0:
  1202                 continue

  This stops the needed space from being a negative number.

  [Regression Potential]
  Other than a typo in the change there won't be any.

  [Original Description]
  In my case I ran out of diskspace in /usr which required a temporary 4 GB of more data during upgrade. Things just start to fail, and I can tell you - then you are screwed. I find this unacceptable for a wide-spread official LTS upgrader.

  ProblemType: BugDistroRelease: Ubuntu 18.04
  Package: ubuntu-release-upgrader-core 1:18.04.22
  ProcVersionSignature: Ubuntu 4.15.0-30.32-generic 4.15.18
  Uname: Linux 4.15.0-30-generic x86_64
  NonfreeKernelModules: nvidia_modeset nvidia
  ApportVersion: 2.20.9-0ubuntu7.2
  Architecture: amd64
  CrashDB: ubuntu
  CurrentDesktop: KDE
  Date: Fri Aug 10 15:14:33 2018
  InstallationDate: Installed on 2016-01-11 (941 days ago)
  InstallationMedia: Kubuntu 14.04.3 LTS "Trusty Tahr" - Beta amd64 (20150805)
  PackageArchitecture: allSourcePackage: ubuntu-release-upgrader
  Symptom: release-upgrade
  UpgradeStatus: Upgraded to bionic on 2018-08-09 (0 days ago)
  mtime.conffile..etc.update-manager.release-upgrades: 2018-08-06T15:08:30.181962

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1786484/+subscriptions