[Bug 1775307] Re: Unattended-upgrades crashes in adjusting candidates in 1.2ubuntu1 version

[Balint Reczey]

Tested 1.1ubuntu1.18.04.7~16.04.1. Candidates are adjusted and u-u does
not crash:

root at x-uu-ref:~# dpkg -l unattended-upgrades | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                Version                    Architecture Description
+++-===================-==========================-============-===========================================
ii  unattended-upgrades 1.1ubuntu1.18.04.7~16.04.1 all          automatic installation of security upgrades
root at x-uu-ref:~# grep invoke /var/lib/dpkg/info/unattended-upgrades.prerm
root at x-uu-ref:~# unattended-upgrade --dry-run --verbose --debug
Initial blacklisted packages: 
Initial whitelisted packages: 
Starting unattended upgrades script
Allowed origins are: o=Ubuntu,a=xenial, o=Ubuntu,a=xenial-security, o=UbuntuESM,a=xenial
Using (^linux-image|^linux-headers|^linux-image-extra|^linux-modules|^linux-modules-extra|^linux-signed-image|^kfreebsd-image|^kfreebsd-headers|^gnumach-image|^.*-modules|^.*-kernel|^linux-backports-modules-.*|^linux-modules-.*|^linux-tools|^linux-cloud-tools) regexp to find kernel packages
Using (^linux-image.*4.19.0-12-generic|^linux-headers.*4.19.0-12-generic|^linux-image-extra.*4.19.0-12-generic|^linux-modules.*4.19.0-12-generic|^linux-modules-extra.*4.19.0-12-generic|^linux-signed-image.*4.19.0-12-generic|^kfreebsd-image.*4.19.0-12-generic|^kfreebsd-headers.*4.19.0-12-generic|^gnumach-image.*4.19.0-12-generic|4.19.0-12-generic.*-modules|4.19.0-12-generic.*-kernel|^linux-backports-modules-.*.*4.19.0-12-generic|^linux-modules-.*.*4.19.0-12-generic|^linux-tools.*4.19.0-12-generic|^linux-cloud-tools.*4.19.0-12-generic) regexp to find running kernel packages
Checking: cloud-init ([<Origin component:'main' archive:'xenial-proposed' origin:'Ubuntu' label:'Ubuntu' site:'archive.ubuntu.com' isTrusted:True>])
adjusting candidate version: cloud-init=0.7.7~bzr1212-0ubuntu1
Checking: kmod ([<Origin component:'main' archive:'xenial-proposed' origin:'Ubuntu' label:'Ubuntu' site:'archive.ubuntu.com' isTrusted:True>])
adjusting candidate version: kmod=22-1ubuntu5
Checking: libc-bin ([<Origin component:'main' archive:'xenial-proposed' origin:'Ubuntu' label:'Ubuntu' site:'archive.ubuntu.com' isTrusted:True>])
adjusting candidate version: libc-bin=2.23-0ubuntu10
Checking: libc6 ([<Origin component:'main' archive:'xenial-proposed' origin:'Ubuntu' label:'Ubuntu' site:'archive.ubuntu.com' isTrusted:True>])
adjusting candidate version: libc6=2.23-0ubuntu10
Checking: libkmod2 ([<Origin component:'main' archive:'xenial-proposed' origin:'Ubuntu' label:'Ubuntu' site:'archive.ubuntu.com' isTrusted:True>])
adjusting candidate version: libkmod2=22-1ubuntu5
Checking: locales ([<Origin component:'main' archive:'xenial-proposed' origin:'Ubuntu' label:'Ubuntu' site:'archive.ubuntu.com' isTrusted:True>])
adjusting candidate version: locales=2.23-0ubuntu10
Checking: multiarch-support ([<Origin component:'main' archive:'xenial-proposed' origin:'Ubuntu' label:'Ubuntu' site:'archive.ubuntu.com' isTrusted:True>])
adjusting candidate version: multiarch-support=2.23-0ubuntu10
Checking: python-apt-common ([<Origin component:'main' archive:'xenial-proposed' origin:'Ubuntu' label:'Ubuntu' site:'archive.ubuntu.com' isTrusted:True>])
adjusting candidate version: python-apt-common=1.1.0~beta1build1
Checking: snapd ([<Origin component:'main' archive:'xenial-proposed' origin:'Ubuntu' label:'Ubuntu' site:'archive.ubuntu.com' isTrusted:True>])
adjusting candidate version: snapd=2.0.2
Checking: ubuntu-core-launcher ([<Origin component:'main' archive:'xenial-proposed' origin:'Ubuntu' label:'Ubuntu' site:'archive.ubuntu.com' isTrusted:True>])
adjusting candidate version: ubuntu-core-launcher=1.0.27.1
pkgs that look like they should be upgraded: 
Fetched 0 B in 0s (0 B/s)                                                                                         
fetch.run() result: 0
blacklist: []
whitelist: []
No packages found that can be upgraded unattended and no pending auto-removals
root at x-uu-ref:~#

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to unattended-upgrades in Ubuntu.
https://bugs.launchpad.net/bugs/1775307

Title:
  Unattended-upgrades crashes in adjusting candidates in 1.2ubuntu1
  version

Status in unattended-upgrades package in Ubuntu:
  Fix Released
Status in unattended-upgrades source package in Xenial:
  Fix Committed
Status in unattended-upgrades source package in Bionic:
  Fix Released

Bug description:
  [Impact]

   * Unattended-upgrades fails to install updates when adjusting
  candidates is needed.

  [Test Case]

  Note that only 1.2ubuntu1 is affected. Earlier releases either did not
  crash or did not adjust candidates due to LP: #1775292. To reproduce
  the crash Cosmic's u-u 1.2ubuntu1 needs to be installed.

   * Run sudo apt update && sudo unattended-upgrade --dry-run --verbose --debug
   * Observe no line with "adjusting candidate version: " or a crash with buggy u-u versions
  ...
  adjusting candidate version: zfs-initramfs=0.7.5-1ubuntu15
  adjusting candidate version: zfs-test=0.7.5-1ubuntu15
  adjusting candidate version: zfs-zed=0.7.5-1ubuntu15
  adjusting candidate version: zfsutils-linux=0.7.5-1ubuntu15
  Traceback (most recent call last):
    File "/usr/bin/unattended-upgrade", line 1928, in <module>
      sys.exit(main(options))
    File "/usr/bin/unattended-upgrade", line 1554, in main
      allowed_origins=allowed_origins)
    File "/usr/bin/unattended-upgrade", line 122, in __init__
      apt.Cache.__init__(self, rootdir=rootdir)
    File "/usr/lib/python3/dist-packages/apt/cache.py", line 130, in __init__
      self.open(progress)
    File "/usr/bin/unattended-upgrade", line 152, in open
      self.adjust_candidates()
    File "/usr/bin/unattended-upgrade", line 161, in adjust_candidates
      for pkgname, candidate in self._get_candidates_to_adjust():
  ValueError: too many values to unpack (expected 2) * Install fixed u-u version

   * Run sudo unattended-upgrade --dry-run --verbose --debug
   * Observe lines "adjusting candidate version: " and no crash

  [Regression Potential]

   * Unattended-upgrade may crash when adjusting candidates preventing
  upgrades to be installed

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1775307/+subscriptions