[Bug 1771858] Re: /snap/bin not in default PATH for units, snapd should ship system-environment-generators to inject /snap/bin into $PATH

[Jon Wedaman]

Just noticed what might be a regression from this fix.
`/usr/local/sbin:/usr/local/bin` are now missing from unit on newest
ubuntu bionic ami (us-east-1: ami-012fd5eb46f56731f)

ubuntu at ubuntu:~$ dpkg-query -W systemd
systemd 237-3ubuntu10.11
ubuntu at ubuntu:~$ sudo systemd-run /usr/bin/env
Running as unit: run-r6c6668bf9774455dbb628d2d79de5949.service
ubuntu at ubuntu:~$ journalctl -e | grep PATH=
Feb 01 20:46:24 ubuntu env[6051]: PATH=/sbin:/usr/sbin:/bin:/usr/bin:/snap/bin

The prior ami (us-east-1: ami-0b86cfbff176b7d3a) doesn't have this
issue. So I checked for differences. I noticed that if I remove
`/usr/lib/systemd/system-environment-generators/snapd-env-generator` and
reboot then I get better output:

ubuntu at ubuntu:~$ sudo systemd-run /usr/bin/env
Running as unit: run-r6c6668bf9774455dbb628d2d79de5949.service
ubuntu at ubuntu:~$ journalctl -e | grep PATH=
Feb 01 20:51:44 ubuntu env[3337]: PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to systemd in Ubuntu.
https://bugs.launchpad.net/bugs/1771858

Title:
  /snap/bin not in default PATH for units, snapd should ship system-
  environment-generators to inject /snap/bin into $PATH

Status in snapd package in Ubuntu:
  Confirmed
Status in systemd package in Ubuntu:
  Fix Released
Status in snapd source package in Xenial:
  Confirmed
Status in systemd source package in Xenial:
  Confirmed
Status in snapd source package in Bionic:
  Confirmed
Status in systemd source package in Bionic:
  Fix Committed
Status in snapd source package in Cosmic:
  Confirmed
Status in systemd source package in Cosmic:
  Fix Released

Bug description:
  [Impact]

   * This means that software installed via snap isn't transparently
  available for units to use.  As snaps are first-class citizens in
  Ubuntu, we should update the PATH.

   * When a generator started to be provided by systemd, it was
  recognized that $PATH is not correctly set, nonetheless, due to an
  environment bug that systemd generators run in.

  [Testcase]

  $ systemd-run /usr/bin/env
  $ journalctl -e | grep PATH

  Output should contain /snap/bin

  Output should contain a complete and a valid PATH, i.e.
  PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin" or similar.

  [Regression Potential]

   * snapd generator was already fixed separately to cause no harm, when
  running under a broken systemd. With the corrected environment,
  generators will now run with a correct PATH out of the box. A slight
  change of PATH will be observed by all generators, when running in
  containers/initramfs-less boots. However most generators will not be
  affected as they typically do not execute external binaries.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1771858/+subscriptions